Skip to content

fix pep E303 in modular/ and algebras/ #35117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2023
Merged

fix pep E303 in modular/ and algebras/ #35117

merged 1 commit into from
Mar 26, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

One step in cleaning pycodestyle E303 (too many blank lines).

Done here in modular/ and algebras/ subfolders

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 858a46f

@edgarcosta
Copy link
Member

LGTM

@edgarcosta edgarcosta self-requested a review February 13, 2023 16:52
@codecov-commenter
Copy link

Codecov Report

Base: 88.58% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (858a46f) compared to base (293dd72).
Patch coverage: 84.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #35117   +/-   ##
========================================
  Coverage    88.58%   88.59%           
========================================
  Files         2140     2140           
  Lines       396961   396961           
========================================
+ Hits        351655   351678   +23     
+ Misses       45306    45283   -23
Impacted Files Coverage Δ
src/sage/modular/abvar/cuspidal_subgroup.py 95.45% <0.00%> (ø)
src/sage/modular/local_comp/local_comp.py 65.37% <0.00%> (ø)
src/sage/modular/modform/ambient_R.py 92.98% <ø> (ø)
src/sage/modular/modform/cuspidal_submodule.py 96.08% <ø> (ø)
src/sage/modular/modform/eis_series.py 98.05% <ø> (ø)
src/sage/modular/modform/numerical.py 94.19% <ø> (-0.65%) ⬇️
...ge/modular/modform_hecketriangle/abstract_space.py 87.47% <ø> (ø)
.../sage/modular/modform_hecketriangle/constructor.py 93.33% <ø> (ø)
src/sage/modular/modsym/subspace.py 96.61% <ø> (ø)
src/sage/modular/modsym/ambient.py 92.64% <50.00%> (ø)
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vbraun vbraun merged commit 8c79fac into sagemath:develop Mar 26, 2023
@fchapoton fchapoton deleted the fix_E303_in_modular_and_algebras branch July 16, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@edgarcosta edgarcosta edgarcosta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fchapoton @edgarcosta @codecov-commenter @vbraun @kwankyu @mkoeppe