Skip to content

Make the key polynomials know their degree #35115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2023
Merged

Make the key polynomials know their degree #35115

merged 1 commit into from
Mar 26, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Feb 13, 2023

📚 Description

Key polynomials know they are graded, but they do not know how to compute their degree.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim tscrim changed the title Made the key polynomials know their degree. Make the key polynomials know their degree Feb 13, 2023
@tscrim
Copy link
Collaborator Author

tscrim commented Feb 13, 2023

@trevorkarn Here is the fix we discussed.

fchapoton
fchapoton approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hope that the TestSuite passes.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: f27866a

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 14, 2023

Thank you!

@trevorkarn
Copy link
Contributor

Thanks for taking care of this @tscrim!

@vbraun vbraun merged commit 06db831 into sagemath:develop Mar 26, 2023
@tscrim tscrim deleted the combinat/graded_keys branch April 28, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: combinatorics p: critical / 2 t: bug
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tscrim @trevorkarn @fchapoton @vbraun @kwankyu @mkoeppe