Skip to content

Partly fix conda ci and update python versions tested #35111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2023
Merged

Partly fix conda ci and update python versions tested #35111

merged 4 commits into from
Mar 26, 2023

Conversation

tobiasdiez
Copy link
Contributor

📚 Description

Currently, the conda ci workflow fails on ubuntu (https://github.com/sagemath/sage/actions/runs/4158846126/jobs/7194339951) due to conda/conda#12303 and/or actions/runner-images#6910. We fix this for the time being by downgrading conda to 4.12 as recommended in actions/runner-images#6910 (comment).

Moreover, the python versions tested is updated to >= 3.9.

This doesn't completely fix the conda workflow though. There seem to be quite a few upstream issues as revealed in https://github.com/tobiasdiez/sage/actions/runs/4160653080:

  • package pytz-deprecation-shim-0.1.0.post0-py310hff52083_1 requires python_abi 3.10.* *_cp310, but none of the providers can be installed (on python 3.9)
  • package dot2tex-2.11.3-pyhd8ed1ab_0 requires python >=3.8, but none of the providers can be installed (this is strange as python version is actually >=3.9)
  • package python-2.7.14-0 requires readline 6.2*, but none of the providers can be installed (not sure who pulls in python 2.7)
  • package python-3.11.0-h582c2e5_0_cpython requires libzlib >=1.2.13,<1.3.0a0, but none of the providers can be installed
  • package memory-allocator-0.1.1-py310h6acc77f_1 requires python_abi 3.10.* *_cp310, but none of the providers can be installed (on python 3.11)
  • package rpy2-2.9.4-py37r341h941a26a_1 requires readline >=7.0,<8.0a0, but none of the providers can be installed
  • package mathics3-1.1.0-py36h20b66c6_2 requires python_abi 3.6.* *_cp36m, but none of the providers can be installed
  • package primecountpy-0.1.0-py310h2fea185_1 requires python_abi 3.10.* *_cp310, but none of the providers can be installed (on python 3.11)
  • package pynormaliz-2.17-py311hc4645bb_1 requires python_abi 3.11.* *_cp311, but none of the providers can be installed (strangly this was on python 3.11)

Maybe some of these are related to #34776. CC: @isuruf

But at least now the standard build on python 3.9 and 3.10 starts, so I would propose to get this in and then work in follow-up PRs on fixing the remaining issues.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023 •
edited
Loading

Codecov Report

Base: 88.58% // Head: 88.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a6f524e) compared to base (293dd72).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #35111   +/-   ##
========================================
  Coverage    88.58%   88.58%           
========================================
  Files         2140     2140           
  Lines       396961   396961           
========================================
+ Hits        351655   351656    +1     
+ Misses       45306    45305    -1
Impacted Files Coverage Δ
src/sage/combinat/posets/poset_examples.py 87.53% <0.00%> (-1.15%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/cpython/_py2_random.py 75.61% <0.00%> (-0.42%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 66.92% <0.00%> (-0.39%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/graphs/generic_graph.py 89.14% <0.00%> (-0.38%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
src/sage/graphs/generators/random.py 92.12% <0.00%> (-0.18%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: a6f524e

@tobiasdiez tobiasdiez requested a review from mkoeppe February 13, 2023 14:59
mkoeppe
mkoeppe approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobiasdiez
Copy link
Contributor Author

Thanks!

@vbraun vbraun merged commit 90f14dc into sagemath:develop Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: porting
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tobiasdiez @codecov-commenter @mkoeppe @vbraun @kwankyu