Skip to content

symbolics: add derivative operator #35193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2023
Merged

symbolics: add derivative operator #35193

merged 1 commit into from
Mar 26, 2023

Conversation

spaghettisalat
Copy link
Contributor

@spaghettisalat spaghettisalat commented Feb 24, 2023 •
edited by mkoeppe
Loading

This allows for also using the syntax which sagemath already uses in the output of symbolic derivatives of functions like D[0,1](f)(x+y,x-y) in user input.

Resolves #32554
Resolves #17445

mkoeppe
mkoeppe reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea.

I've made some small edits.

I think it would be good to add an example to the class doctest, so that it will be shown if the user types D?

@spaghettisalat spaghettisalat force-pushed the public/derivative-operator branch from 8913a3a to 210afac Compare February 25, 2023 13:37
@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8913a3a) compared to base (05329f6).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8913a3a differs from pull request most recent head 210afac. Consider uploading reports for the commit 210afac to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35193      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396998   397285     +287     
===========================================
+ Hits        351740   351960     +220     
- Misses       45258    45325      +67
Impacted Files Coverage Δ
src/sage/symbolic/all.py 100.00% <100.00%> (ø)
src/sage/symbolic/operators.py 100.00% <100.00%> (ø)
...e/combinat/cluster_algebra_quiver/mutation_type.py 50.95% <0.00%> (-3.69%) ⬇️
src/sage/plot/histogram.py 96.77% <0.00%> (-3.23%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/modular/quasimodform/element.py 99.14% <0.00%> (-0.86%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.79%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
src/sage/schemes/elliptic_curves/hom.py 83.33% <0.00%> (-0.62%) ⬇️
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@spaghettisalat
Copy link
Contributor Author

I've improved the documentation a bit as requested (and also added a __repr__ method so that the new operator prints nicely).

@egourgoulhon
Copy link
Member

egourgoulhon commented Mar 1, 2023 •
edited
Loading

Thanks for implementing this new feature!

egourgoulhon
egourgoulhon suggested changes Mar 1, 2023
View reviewed changes
@spaghettisalat
symbolics: add derivative operator
76c6eb0 
This allows for also using the syntax which sagemath already uses in
the output of symbolic derivatives of functions like
`D[0,1](f)(x+y,x-y)` in user input.
@spaghettisalat spaghettisalat force-pushed the public/derivative-operator branch from 210afac to 76c6eb0 Compare March 2, 2023 18:16
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 76c6eb0

@roed314
Copy link
Contributor

roed314 commented Mar 4, 2023

I'm fine with this, but am leaving the positive review for others who work with symbolics more than I do.

egourgoulhon
egourgoulhon approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me too!
Thanks.

@vbraun vbraun merged commit bd8ede6 into sagemath:develop Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@egourgoulhon egourgoulhon egourgoulhon approved these changes

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: symbolics
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

Add derivative operator Document derivative operator and notations
7 participants
@spaghettisalat @codecov-commenter @egourgoulhon @roed314 @mkoeppe @vbraun @kwankyu