Skip to content

Categories for Family #35175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 36 commits into
base: develop
Choose a base branch
from
Draft

Categories for Family #35175

wants to merge 36 commits into from

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 22, 2023

📚 Description

Fixes #34340

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.59% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (a65bd95) compared to base (05329f6).
Patch coverage: 94.28% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35175      +/-   ##
===========================================
- Coverage    88.59%   88.59%   -0.01%     
===========================================
  Files         2140     2143       +3     
  Lines       396998   397093      +95     
===========================================
+ Hits        351740   351800      +60     
- Misses       45258    45293      +35
Impacted Files Coverage Δ
src/sage/quivers/path_semigroup.py 92.88% <ø> (ø)
src/sage/categories/families.py 89.47% <89.47%> (ø)
src/sage/sets/family.py 96.44% <93.81%> (-0.83%) ⬇️
src/sage/algebras/jordan_algebra.py 94.73% <100.00%> (+0.08%) ⬆️
src/sage/categories/enumerated_families.py 100.00% <100.00%> (ø)
...rc/sage/categories/finitely_enumerated_families.py 100.00% <100.00%> (ø)
src/sage/sets/set.py 93.30% <100.00%> (+0.06%) ⬆️
...e/combinat/cluster_algebra_quiver/mutation_type.py 51.18% <0.00%> (-3.45%) ⬇️
src/sage/modular/local_comp/liftings.py 98.33% <0.00%> (-1.67%) ⬇️
src/sage/combinat/posets/poset_examples.py 87.67% <0.00%> (-0.86%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Matthias Koeppe added 28 commits February 15, 2024 23:20
@mkoeppe
Family: Pass keyword 'category' through to implementation classes
d2b0c4a
@mkoeppe
src/sage/sets/family.py: Expand doc, clarify relationship to collecti…
9101ad8 
…ons.abc and the Sets() category
@mkoeppe
src/sage/sets/family.py: Accept init arg 'category' in Family impleme…
f5f53ae 
…ntation classes
@mkoeppe
src/sage/sets/family.py: Update copyright according to git blame -w -…
7db051c 
…-date=format:%Y FILE | sort -k2
@mkoeppe
src/sage/sets/family.py: Improve some docstring markup
3695687
@mkoeppe
src/sage/sets/family.py: Add example with an uncountable index set
2f4ad28
@mkoeppe
src/sage/sets/family.py: NOTE -> WARNING, talk about factory later
18d998a
@mkoeppe
src/sage/sets/family.py: Fix markup
69f5aff
@mkoeppe
LazyFamily: Handle keyword is_injective, delegate to ImageSubset
53fcc31
@mkoeppe
LazyFamily: Make 'values' an iterator, add iterator 'items', add meth…
9d49862 
…od 'as_set'
@mkoeppe
LazyFamily.values: Fix up
42de203
@mkoeppe
LazyFamily._element_constructor_: Fix up
2a33092
@mkoeppe
LazyFamily: Construct the ImageSubobject in as_set, change uses
ddf8abe
@mkoeppe
AbstractFamily.as_set: New
e9d5399
@mkoeppe
src/sage/sets/family.py: Update documentation
32ee659
@mkoeppe
src/sage/sets/family.py: Add doctests
56d5ee8
@mkoeppe
SpecialJordanAlgebra.gens(): Do not try to make a tuple from an infin…
edc9f39 
…ite iterable
@mkoeppe
src/sage/quivers/path_semigroup.py: Fix doctest output
a9f687d
@mkoeppe
Family: Pass on keywords is_injective, inverse; implement _element_co…
cbf4e9c 
…nstructor_
@mkoeppe
src/sage/sets/family.py: Expand polyhedral example
04061ce
@mkoeppe
TrivialFamily.values: New
8fe00e0
@mkoeppe
Set(X): First try X.as_set()
d78a360
@mkoeppe
src/sage/categories/families.py: New
abfefc1
@mkoeppe
src/sage/categories/families.py: Add example
6479321
@mkoeppe
src/sage/categories/enumerated_families.py: New
83add92
@mkoeppe
src/sage/sets/family.py: Use category EnumeratedFamilies
a9ffdc8
@mkoeppe
src/doc/en/reference/categories/index.rst: Add new files
cf01ffc
@mkoeppe
src/sage/sets/family.py: WIP facade families
da9ab39
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 7161c00; changes) is ready! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkoeppe mkoeppe

Labels
c: categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categories for Family
2 participants
@mkoeppe @codecov-commenter