Skip to content

RealDoubleFieldElement without GSL: Add missing methods #35158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

RealDoubleFieldElement without GSL: Add missing methods #35158

wants to merge 11 commits into from

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 18, 2023

📚 Description

Fixes #32779

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Matthias Koeppe added 9 commits February 18, 2023 11:41
@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (703339c) compared to base (fbb4127).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35158      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396961              
===========================================
- Hits        351677   351666      -11     
- Misses       45284    45295      +11
Impacted Files Coverage Δ
src/sage/cpython/_py2_random.py 74.38% <0.00%> (-2.07%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 50.95% <0.00%> (-2.02%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.79%) ⬇️
src/sage/combinat/constellation.py 91.18% <0.00%> (-0.41%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/modular/overconvergent/hecke_series.py 98.76% <0.00%> (-0.31%) ⬇️
src/sage/quadratic_forms/ternary_qf.py 66.92% <0.00%> (-0.20%) ⬇️
src/sage/combinat/posets/poset_examples.py 88.53% <0.00%> (-0.15%) ⬇️
src/sage/schemes/elliptic_curves/ell_generic.py 93.23% <0.00%> (-0.14%) ⬇️
src/sage/combinat/posets/posets.py 93.87% <0.00%> (-0.12%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mezzarobba
mezzarobba reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise!

Matthias Köppe and others added 2 commits February 21, 2023 11:03
@mkoeppe @mezzarobba
src/sage/rings/real_double.pyx: Use RDF.coerce
bd0e011 
Co-authored-by: Marc Mezzarobba <marc@mezzarobba.net>
@mkoeppe
Merge branch 'develop' into t/32779/realdoublefieldelement_without_gs…
a36c9f7 
…l__add_missing_methods
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 21, 2023

Thank you!

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: a36c9f7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 21, 2023

I've committed your suggested change, and it still passes tests. So I'm setting to positive review.

@vbraun
Copy link
Member

vbraun commented Mar 24, 2023

On OSX I get:

**********************************************************************
File "src/sage/rings/real_double.pyx", line 2156, in sage.rings.real_double.RealDoubleElement.tan
Failed example:
    RealDoubleElement.tan(q)
Expected:
    0.5773502691896257
Got:
    0.5773502691896256
**********************************************************************
1 item had failures:
   1 of   6 in sage.rings.real_double.RealDoubleElement.tan
    [373 tests, 1 failure, 0.23 s]
----------------------------------------------------------------------
sage -t --long --random-seed=0 src/sage/rings/real_double.pyx  # 1 doctest failed
----------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mezzarobba mezzarobba mezzarobba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mkoeppe mkoeppe

Labels
s: needs work t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RealDoubleFieldElement without GSL: Add missing methods
4 participants
@mkoeppe @codecov-commenter @vbraun @mezzarobba