Skip to content

qqbar.clear_denominators: crude but fast alternative algorithm #34961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

qqbar.clear_denominators: crude but fast alternative algorithm #34961

merged 1 commit into from
Mar 3, 2023

Conversation

mezzarobba
Copy link
Member

@mezzarobba mezzarobba commented Feb 6, 2023 •
edited
Loading

Fixes #33810.

@codecov-commenter
Copy link

Codecov Report

Base: 88.59% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7eaeab6) compared to base (200557e).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #34961   +/-   ##
========================================
  Coverage    88.59%   88.59%           
========================================
  Files         2136     2136           
  Lines       396141   396143    +2     
========================================
+ Hits        350964   350978   +14     
+ Misses       45177    45165   -12
Impacted Files Coverage Δ
src/sage/rings/qqbar.py 95.30% <100.00%> (+<0.01%) ⬆️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.48% <0.00%> (-1.58%) ⬇️
src/sage/crypto/stream.py 74.73% <0.00%> (-1.06%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.90%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 50.23% <0.00%> (-0.48%) ⬇️
src/sage/graphs/tutte_polynomial.py 93.57% <0.00%> (-0.46%) ⬇️
src/sage/rings/polynomial/ore_polynomial_ring.py 89.40% <0.00%> (-0.43%) ⬇️
src/sage/modular/arithgroup/arithgroup_perm.py 92.57% <0.00%> (-0.38%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mezzarobba mezzarobba marked this pull request as ready for review February 6, 2023 17:17
@mezzarobba mezzarobba changed the title qqbar.clear_denominators: crude but fast alt algo qqbar.clear_denominators: crude but fast alternative algorithm Feb 6, 2023
videlec
videlec reviewed Feb 6, 2023
View reviewed changes
src/sage/rings/qqbar.py
for f, e in factors.items():
change = change * f**e
denoms = [c.denominator() for c in poly]
if all(d.nbits() < 128 for d in denoms):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 128 just a random threshold?

@mezzarobba
Copy link
Member Author

mezzarobba commented Feb 7, 2023 via email

@mezzarobba mezzarobba force-pushed the 33810-exactify_ifactor branch from 7eaeab6 to 9cc8d1a Compare February 7, 2023 19:58
@mezzarobba mezzarobba force-pushed the 33810-exactify_ifactor branch from 9cc8d1a to 4d08c4d Compare February 8, 2023 10:23
@mezzarobba
Copy link
Member Author

Thanks!

@vbraun vbraun merged commit 23ab380 into sagemath:develop Mar 3, 2023
@mezzarobba mezzarobba deleted the 33810-exactify_ifactor branch December 6, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@videlec videlec videlec approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: algebra p: major / 3
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.

AlgebraicNumber.exactify() factors integers
6 participants
@mezzarobba @codecov-commenter @videlec @vbraun @kwankyu @mkoeppe