Skip to content

remove some deprecations in matrix2 #40711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 7, 2025
Merged

remove some deprecations in matrix2 #40711

merged 7 commits into from
Sep 7, 2025

Conversation

fchapoton
Copy link
Contributor

after

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

dcoudert
dcoudert reviewed Aug 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 44c203b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert
Copy link
Contributor

some doctests are failing, for instance in src/doc/en/prep/Quickstarts/Linear-Algebra.rst

@dcoudert
Copy link
Contributor

other failing doctests

ImportError: cannot import name 'BackslashOperator' from 'sage.misc.misc' (/sage/src/sage/misc/misc.py)
Error: Process completed with exit code 1.

@fchapoton
Copy link
Contributor Author

there remains something there

git grep BackslashOperator src/
src/sage/repl/preparse.py:        'A  * BackslashOperator() * B'
src/sage/repl/preparse.py:        'A**Integer(2)  * BackslashOperator() * B + C'
src/sage/repl/preparse.py:        'a  * BackslashOperator() * b \\'
src/sage/repl/preparse.py:    L = re.sub(r'''\\\s*([^\t ;#])''', r' * BackslashOperator() * \1', L)

that must be removed maybe ?

@dcoudert
Copy link
Contributor

it seems related, so yes, it should also be removed.

@dcoudert
Copy link
Contributor

Apparently this is not enough

@fchapoton
Copy link
Contributor Author

aargh.. bien pénible

@dcoudert
Copy link
Contributor

oui, ça semble compliqué et il y a encore des soucis dans src/doc/en/prep/Quickstarts/Linear-Algebra.rst

dcoudert
dcoudert approved these changes Aug 30, 2025
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 7a2ef2f into sagemath:develop Sep 7, 2025
23 of 25 checks passed
@fchapoton fchapoton deleted the deprec_matrix2 branch September 7, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun