-
-
Notifications
You must be signed in to change notification settings - Fork 654
Update versions for matplotlib and dependencies #40633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
It seems that the download link of matplotlib_inline is broken, we need to use |
Documentation preview for this PR (built with commit 369ebde; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates matplotlib from version 3.10.1 to 3.10.5 and bumps several of its dependencies to their latest versions for compatibility and security updates.
- Updates matplotlib to version 3.10.5
- Updates dependency versions including numpy, pillow, pytz, and other matplotlib-related packages
- Updates corresponding SHA1 and SHA256 checksums for all package updates
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
build/pkgs/matplotlib/package-version.txt | Updates matplotlib version to 3.10.5 |
build/pkgs/matplotlib/checksums.ini | Updates checksums for matplotlib 3.10.5 |
build/pkgs/numpy/package-version.txt | Updates numpy dependency to 2.3.2 |
build/pkgs/numpy/checksums.ini | Updates checksums for numpy 2.3.2 |
build/pkgs/pillow/package-version.txt | Updates pillow dependency to 11.3.0 |
build/pkgs/pillow/checksums.ini | Updates checksums for pillow 11.3.0 |
build/pkgs/pytz/package-version.txt | Updates pytz dependency to 2025.2 |
build/pkgs/pytz/checksums.ini | Updates checksums for pytz 2025.2 |
build/pkgs/matplotlib_inline/package-version.txt | Updates matplotlib_inline to 0.1.7 |
build/pkgs/matplotlib_inline/checksums.ini | Updates checksums for matplotlib_inline 0.1.7 |
build/pkgs/kiwisolver/package-version.txt | Updates kiwisolver dependency to 1.4.9 |
build/pkgs/kiwisolver/checksums.ini | Updates checksums for kiwisolver 1.4.9 |
build/pkgs/contourpy/package-version.txt | Updates contourpy dependency to 1.3.3 |
build/pkgs/contourpy/checksums.ini | Updates checksums for contourpy 1.3.3 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
please also bump meson_python to version 0.18. |
The latter, and one more related fix, are in cxzhong#3 - please merge this to incorporate my changes |
more fixes for PR sagemath#40633
Seems that CI has failed. It also failed in my local host. It seems the bug in meson-python 0.18.0 |
without the patch, we get [meson_python-0.18.0] [spkg-install] meson-python: error: Field "project.license" has an invalid type, expecting a dictionary of strings (got "MIT")
yes. I have a fix - cxzhong#4 |
fix format of the license (sic!)
Maybe we need to upgrade pyproject_metadate. you can revert the lastest commit and check that. |
@dimpase Thank you very much. I have bumped pyproject_metadate to 0.9.1. It seems OK now. Just wait for the CI |
yes, I was about to send you another PR to fix this. We really should not manage our Python dependencies in our ancient way... |
In |
These |
OK, it seems good in workflow. I think it can be merged. |
this fixes builds on a number of Linux distros, thus I added a blocker here. @vbraun |
what makes you think it's done there? |
Regarding #40586 (comment):
I don't know... The branch is just the merge of #40633 and #40586. Hence it has the previous setuptools. Perhaps your branch does not work with the previous setuptools, at least on mac. |
Sorry, I don't know what you mean. How is that related with my test on mac? |
Downgrading Pillow to 11.1.0 with the merge of #40633 and #40586 works for me. Pillow is installed successfully. |
moreover we have
sagemath installed. |
that was comment on the priority of PRs. |
jupyter(lab) packaged with Sage stopped normally working on my Linux laptop quite a while ago, as I keep getting annoyng pop-ups saying For running sphinx, it doesn't really matter, but it also does not need that many jupyter-related packages. By the way, on a macOS machine I am testing this (with #39030), I get
and at least docs (html and pdf) build fine - I didn't try interactive jupyter. On the Linux machine I am testing this, I get a very similar configuration
and docs (html and pdf) build fine. But Sage's jupyter has this annoying bug I mentioned above, which of course is not relevant, it just shows that we running hopelessly behind with our manual updates. The only real way out is to stop vendoring jupyter and sphinx, and get them from PyPI, the latest versions, probably. |
what's the point of downgrading Pillow? One should understand why it's not installable in the configuration you have. |
To recover the sagemath kernel and revive doc-release, #40586 restores the previous setuptools. Apparently Pillow 11.3.0 is not compatible with the previous setuptools. I guess upgrading Pillow is not urgent. Pillow may be upgraded when someone understands why the recent setuptools fails to install the sagemath kernel. |
and why is previous setuptools needed? is there an explanation, other that "kernel does not get installed, I don't know why" ? |
there is no explanation other that "kernel does not get installed, I don't know why". |
Do you know why? |
The branch works well with #40586. Thanks! |
Thank you. |
It's most probably not setuptools itself, but some other package which uses setuptools, right? |
sagemathgh-40633: Update versions for matplotlib and dependencies Just bump matplotlib to 3.10.5 and them dependencies. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40633 Reported by: Chenxin Zhong Reviewer(s): Copilot, Dima Pasechnik
I guess that installing sagemath kernel is part of installing sagelib. The up-to-date setuptools somehow seems to fail it. I have no idea how. It is just mysterious to me. |
We looked at it last month and have not found any way out (well, no way to do this non-explicitly), because it's indeed an artefact of something outdated; the fix is to explicitly call jupyter to install the kernel. jupyter kernelspec install --name=sagemath --user build/sage-distro/src/sage which is working for an up to date jupterlab+dependencies (and new setuptool, as the old doesn't support everything needed) - this commit is a part of #39030. |
Just bump matplotlib to 3.10.5 and them dependencies.
📝 Checklist
⌛ Dependencies