Skip to content

Delete one appearance of sage-python #40526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2025
Merged

Delete one appearance of sage-python #40526

merged 1 commit into from
Aug 9, 2025

Conversation

enriqueartal
Copy link
Contributor

In #40490, sage-python has been replaced by python3 and one bin/sage-python has been erased, while other one is still there, erase it also.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2025

Documentation preview for this PR (built with commit 93c7de0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Aug 2, 2025

#40490 removed sage-python. Just rename any remaining occurrence of the latter to python3.

dimpase
dimpase approved these changes Aug 2, 2025
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it's actually not "called", it's just mentioned.

@tobiasdiez
Copy link
Contributor

Thanks! (sagemath-enviroment should probably deleted completely, there is no point in installing parts of sagelib again)

@user202729 user202729 added the p: CI Fix merged before running CI tests label Aug 3, 2025
@user202729 user202729 mentioned this pull request Aug 3, 2025
Closed
2 tasks
@enriqueartal
Copy link
Contributor Author

Thanks! (sagemath-enviroment should probably deleted completely, there is no point in installing parts of sagelib again)

I guess you are right, but for me now it is the only way that I can have a functional sirocco. In the time, just installing sirocco it worked, but now, the libraries are not installed without sagemath-sirocco (which needs sagemath-environment). I have struggled to have a solution without success (may because of lack of knowledge!)

@tobiasdiez
Copy link
Contributor

With #39030 it should build the parts in sagelib relying on sirroco automatically, once you have that library installed.

@enriqueartal
Copy link
Contributor Author

I would be happy to test, but I have no experience in using meson.

@dimpase dimpase mentioned this pull request Aug 8, 2025
Closed
@dimpase
Copy link
Member

dimpase commented Aug 8, 2025

@vbraun - this should be in the upcoming release, no?

@vbraun vbraun merged commit 8514242 into sagemath:develop Aug 9, 2025
28 of 29 checks passed
@kwankyu kwankyu mentioned this pull request Aug 21, 2025
Merged
5 tasks
@enriqueartal enriqueartal deleted the sage-python branch September 8, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dimpase dimpase dimpase approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
p: blocker / 1 p: CI Fix merged before running CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enriqueartal @dimpase @tobiasdiez @vbraun @user202729