Detect error in merge-fixes script #40502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Then it's also a good idea to set continue-on-error on all of these "merge-ci fixes" steps. Otherwise the job will exit early, which doesn't give you any info about if the rest of the code actually would have succeeded. |
it may give false failure though. One can just wait until GitHub API works again and retrigger CI. |
|
Documentation preview for this PR (built with commit b4a32d4; changes) is ready! 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, sometimes the command fails e.g.
https://github.com/sagemath/sage/actions/runs/16582198673/job/46900506860?pr=40497
this detects the error and fails the job, instead of (confusingly) assume there's no CI fix and proceed to test.
📝 Checklist
⌛ Dependencies