Remove useless limitations in Drinfeld modules #40436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Parfait. This limitation on the constant coefficient was useless. Thank you for removing it. We have the same doc-build problem as here, so I'll wait for a solution before approving. |
5 tasks
|
Documentation preview for this PR (built with commit bc7e67d; changes) is ready! 🎉 |
kryzar
reviewed
Aug 11, 2025
|
Done. |
kryzar
approved these changes
Aug 12, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 14, 2025
sagemathgh-40436: Remove useless limitations in Drinfeld modules (1) We authorize Drinfeld modules with constant coefficient zero (which is definitely not discarded by the theory). (2) We automatically coerce the given coefficients to the field of fractions; this avoids one step when creating a Drinfeld module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40436 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
added 2 commits
August 15, 2025 09:30
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 15, 2025
sagemathgh-40436: Remove useless limitations in Drinfeld modules (1) We authorize Drinfeld modules with constant coefficient zero (which is definitely not discarded by the theory). (2) We automatically coerce the given coefficients to the field of fractions; this avoids one step when creating a Drinfeld module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40436 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
|
It seems there is now a merge conflict with #40430, so I merged it manually and resolved the conflict. |
kryzar
reviewed
Aug 16, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40436: Remove useless limitations in Drinfeld modules (1) We authorize Drinfeld modules with constant coefficient zero (which is definitely not discarded by the theory). (2) We automatically coerce the given coefficients to the field of fractions; this avoids one step when creating a Drinfeld module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40436 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40440: Hom spaces between Drinfeld modules We implement a method for computing a basis of the homset between two Drinfeld modules defined over a finite field. Includes sagemath#35386 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40440 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 25, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 25, 2025
sagemathgh-40440: Hom spaces between Drinfeld modules We implement a method for computing a basis of the homset between two Drinfeld modules defined over a finite field. Includes sagemath#35386 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40440 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) We authorize Drinfeld modules with constant coefficient zero (which is definitely not discarded by the theory).
(2) We automatically coerce the given coefficients to the field of fractions; this avoids one step when creating a Drinfeld module.
📝 Checklist
⌛ Dependencies
#40430