-
-
Notifications
You must be signed in to change notification settings - Fork 652
Constructor for the Carlitz module #40433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
src/sage/rings/function_field/drinfeld_modules/carlitz_module.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment in the diff.
Documentation preview for this PR (built with commit b201d77; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely.
(Failing tests (stuff in src/sage/interfaces/gap.py
or internal cuisine) are unrelated to the PR.)
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
Don't understand where the error on |
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
We add a constructor for instantiating easily the Carlitz module.
📝 Checklist
⌛ Dependencies
#40430, #40436