Skip to content

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Jul 17, 2025

This PR implements the relative Frobenius for Drinfeld modules.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#40430

@kryzar kryzar self-requested a review July 17, 2025 15:12
Copy link

github-actions bot commented Aug 4, 2025

Documentation preview for this PR (built with commit d315182; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@kryzar kryzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes and then we'll be good.

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 12, 2025

I applied your suggestions.
And also merge drinfeld_tau in this ticket for compatibility.

@kryzar
Copy link
Contributor

kryzar commented Aug 12, 2025

It's really tedious and frustrating going through each build or test fail individually, just to inevitably note that the problem comes either from internal machinery or a contribution that was not caught. I really hope the maintainers do something about that.

PR approved.

@vbraun
Copy link
Member

vbraun commented Aug 13, 2025

Why are you deleting conftest.py?

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 13, 2025

Why are you deleting conftest.py?

Sorry. It always disappear by itself, I don't know why.

@user202729
Copy link
Contributor

It's really tedious and frustrating going through each build or test fail individually, just to inevitably note that the problem comes either from internal machinery or a contribution that was not caught. I really hope the maintainers do something about that.

PR approved.

I'm frustrated too. I tried to implement #39539 as a workaround, but it isn't working and I don't know why.

For now, I mostly just look at the meson one and if say at most 2 of them are failing then it's probably just flaky tests.

This doesn't work with build-doc or build-doc-pdf however, there's only one run of it. Doesn't help that you need to search through a huge log file for the error.

Why are you deleting conftest.py?

Sorry. It always disappear by itself, I don't know why.

Strange. After #39363 there should be no issue with it.

Unless… the pull request itself is responsible for the disappearing file.

As a workaround (I of course encourage proper fix, but we don't have enough people to look at all these bugs, unfortunately) you can

git update-index --assume-unchanged conftest.py

@user202729
Copy link
Contributor

Yes, documentation build failure is legitimate.

I suggest checking out the documentation preview (see message by github-actions above) to see if it renders correctly. At least I see two places where it's wrong

image

The easiest way to check is to click the "changes is ready" button; however this currently give some false positive, but not so much that it becomes useless.

#40530

@user202729
Copy link
Contributor

user202729 commented Aug 16, 2025

actually the established macro is \newcommand{\GF}[1]{\Bold{F}_{#1}}. (personally I prefer mathbb, but just for consistency with other parts of the code base)

(this macro is available for you to use)

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 16, 2025

Actually, we already use mathbb everywhere in the drinfeld_modules directory.
However, I can switch to GF if you think it's better.

@user202729
Copy link
Contributor

I mean, if people decide mathbb is better than mathbf, it's trivial to change the definition of the GF command at one place.

… but whatever, let's get this in. (if build-doc-pdf is successful and no missing character error)

@kryzar
Copy link
Contributor

kryzar commented Aug 16, 2025

Thanks very much @user202729 for the help and many tips. It's nice.

@xcaruso
Copy link
Contributor Author

xcaruso commented Aug 20, 2025

Looks like the failures are again not related to the PR.
I give back a positive review. Hope this PR will be merged soon :-)

@kryzar
Copy link
Contributor

kryzar commented Aug 20, 2025

Hope this PR will be merged soon :-)

Me too!!!

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 21, 2025
sagemathgh-40432: Implement relative Frobenius for Drinfeld modules
    
This PR implements the relative Frobenius for Drinfeld modules.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40430
    
URL: sagemath#40432
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière, Volker Braun, Xavier Caruso
@vbraun vbraun merged commit 99ae29d into sagemath:develop Aug 27, 2025
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants