Use the variable name τ instead of t for Drinfeld modules #40430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this affect copy & paste, to reuse output? |
|
That's a fair question. In both the current state and the PR, the user has to instantiate a variable (
tau = τ = phi.ore_variable()We acknowledge this is less convenient than the current state (the user has to do a copypasta), but |
|
(@mantepse: we're not sure what your thumb-up means!) |
It means that I am not against the proposed change. |
|
In that case, I looked through each job fail and the culprits seem to be:
PR approved. |
kryzar
approved these changes
Jul 17, 2025
This was referenced Jul 17, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
|
IPython tip: On a normal keyboard, you can type If you're using some editor to edit a p/s: maybe @kryzar want to review the new commit? |
|
Great! Thanks for the tip! |
5 tasks
|
Documentation preview for this PR (built with commit e14b7cf; changes) is ready! 🎉 |
|
Thanks for the tip! |
kryzar
approved these changes
Aug 11, 2025
5 tasks
5 tasks
|
See #40599 |
|
actually I realize the two bugs above are not caused by this PR, so I set this back to positive review. This doesn't break any test either. |
|
Thanks! |
5 tasks
|
I give back a positive review to this PR and all its companions. |
|
personally I have a script to automatically update all the branches I have, and I locally delete the branches that already got positive review so they don't get updated. |
|
Lol I'll let you two handle it |
|
I don't understand what is the problem with the documentation. |
|
PDF documentation failure is unrelated to this change. See #40586 (comment). |
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40432: Implement relative Frobenius for Drinfeld modules This PR implements the relative Frobenius for Drinfeld modules. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40432 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Volker Braun, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40434: gcd and lcm of isogenies of Drinfeld modules We add methods to compute right gcds and left lcms of isogenies between Drinfeld modules. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40434 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40436: Remove useless limitations in Drinfeld modules (1) We authorize Drinfeld modules with constant coefficient zero (which is definitely not discarded by the theory). (2) We automatically coerce the given coefficients to the field of fractions; this avoids one step when creating a Drinfeld module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430 URL: sagemath#40436 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40440: Hom spaces between Drinfeld modules We implement a method for computing a basis of the homset between two Drinfeld modules defined over a finite field. Includes sagemath#35386 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40440 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the theory of Drinfeld module, the classical name of the noncommutative variable is
τ. However, in Sage, we currently uset, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted byt).In this PR, we propose to shift to the notation
τ. It just changes how the outputs are printed (by default), not the interface.📝 Checklist
⌛ Dependencies
#40420, #40421