Remove unnecessary range start #40429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantepse
reviewed
Jul 17, 2025
src/sage/crypto/mq/sr.py
Outdated
| @@ -2289,13 +2289,13 @@ def lin_matrix(self, length=None): | |||
| lin = matrix(self.base_ring(), length*e, length*e) | |||
| if e == 4: | |||
| l = [k.from_integer(x) for x in (5, 1, 12, 5)] | |||
| for k in range( 0, length ): | |||
| for k in range( length ): | |||
There was a problem hiding this comment.
I'd suggest to also remove the spaces, if you are already touching all this.
mantepse
reviewed
Jul 17, 2025
mantepse
reviewed
Jul 17, 2025
Co-authored-by: Martin Rubey <axiomize@yahoo.de>
Co-authored-by: Martin Rubey <axiomize@yahoo.de>
|
thanks for the suggestion @mantepse, the extra whitespaces bug me too but I'm torn between manually fixing these 2 cases or do an autoformatting for the whole file. I decided to stick to only these 2 cases in the end as formatting the whole file will cause a lot of diff |
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40429: Remove unnecessary range start <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Autofix with `ruff check . --select PIE808 --fix`. There are probably > 10k occurrences without the range start and 42 with 0 as the range start, so it's already favored to remove the range start for consistency ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40429 Reported by: Trinh Quoc Anh Reviewer(s): Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autofix with
ruff check . --select PIE808 --fix. There are probably > 10k occurrences without the range start and 42 with 0 as the range start, so it's already favored to remove the range start for consistency📝 Checklist
⌛ Dependencies