Fix GF(2) matrix transpose with subdivisions #40423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Could you also fix the code for "empty" input matrices, i.e. when |
5 tasks
|
I have checked other matrix classes as well and fixed other instances of the zero matrix subdivision problem: |
|
You should add a doctest to show that the bug is indeed fixed. |
|
Doc tests are added now, checking for transposes of both 0-row and 0-column matrices. |
5 tasks
xcaruso
reviewed
Jul 24, 2025
xcaruso
reviewed
Jul 24, 2025
|
I've updated the doctests now. All instances of _subdivisions should be replaced with subdivisions() |
|
Failures look unrelated to this PR. I give a positive review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40423: Fix GF(2) matrix transpose with subdivisions <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. A small bug I noticed when looking at the code for transposing matrices. GF(2) does not properly transpose its subdivisions, meaning transposed matrices can have incorrect subdivisions or cause errors if the indices fall out of range. sage: M = matrix.random(GF(2),3,3) sage: N = matrix.block([[M,M,M]]) sage: M [1 0 0] [0 0 1] [0 1 0] sage: N [1 0 0|1 0 0|1 0 0] [0 0 1|0 0 1|0 0 1] [0 1 0|0 1 0|0 1 0] sage: N.transpose() <repr(<sage.matrix.matrix_mod2_dense.Matrix_mod2_dense at 0x7f1eb7f0c1c0>) failed: IndexError: list index out of range> This also adds subdivision handling to transposes of matrix_complex_ball_dense, matrix_gap, and fixes subdivisions for transposes of empty matrices of type matrix_mod2_dense, matrix_numpy_dense URL: sagemath#40423 Reported by: Biffo89 Reviewer(s): Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40423: Fix GF(2) matrix transpose with subdivisions <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. A small bug I noticed when looking at the code for transposing matrices. GF(2) does not properly transpose its subdivisions, meaning transposed matrices can have incorrect subdivisions or cause errors if the indices fall out of range. sage: M = matrix.random(GF(2),3,3) sage: N = matrix.block([[M,M,M]]) sage: M [1 0 0] [0 0 1] [0 1 0] sage: N [1 0 0|1 0 0|1 0 0] [0 0 1|0 0 1|0 0 1] [0 1 0|0 1 0|0 1 0] sage: N.transpose() <repr(<sage.matrix.matrix_mod2_dense.Matrix_mod2_dense at 0x7f1eb7f0c1c0>) failed: IndexError: list index out of range> This also adds subdivision handling to transposes of matrix_complex_ball_dense, matrix_gap, and fixes subdivisions for transposes of empty matrices of type matrix_mod2_dense, matrix_numpy_dense URL: sagemath#40423 Reported by: Biffo89 Reviewer(s): Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 27, 2025
sagemathgh-40423: Fix GF(2) matrix transpose with subdivisions <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. A small bug I noticed when looking at the code for transposing matrices. GF(2) does not properly transpose its subdivisions, meaning transposed matrices can have incorrect subdivisions or cause errors if the indices fall out of range. sage: M = matrix.random(GF(2),3,3) sage: N = matrix.block([[M,M,M]]) sage: M [1 0 0] [0 0 1] [0 1 0] sage: N [1 0 0|1 0 0|1 0 0] [0 0 1|0 0 1|0 0 1] [0 1 0|0 1 0|0 1 0] sage: N.transpose() <repr(<sage.matrix.matrix_mod2_dense.Matrix_mod2_dense at 0x7f1eb7f0c1c0>) failed: IndexError: list index out of range> This also adds subdivision handling to transposes of matrix_complex_ball_dense, matrix_gap, and fixes subdivisions for transposes of empty matrices of type matrix_mod2_dense, matrix_numpy_dense URL: sagemath#40423 Reported by: Biffo89 Reviewer(s): Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 28, 2025
sagemathgh-40423: Fix GF(2) matrix transpose with subdivisions <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. A small bug I noticed when looking at the code for transposing matrices. GF(2) does not properly transpose its subdivisions, meaning transposed matrices can have incorrect subdivisions or cause errors if the indices fall out of range. sage: M = matrix.random(GF(2),3,3) sage: N = matrix.block([[M,M,M]]) sage: M [1 0 0] [0 0 1] [0 1 0] sage: N [1 0 0|1 0 0|1 0 0] [0 0 1|0 0 1|0 0 1] [0 1 0|0 1 0|0 1 0] sage: N.transpose() <repr(<sage.matrix.matrix_mod2_dense.Matrix_mod2_dense at 0x7f1eb7f0c1c0>) failed: IndexError: list index out of range> This also adds subdivision handling to transposes of matrix_complex_ball_dense, matrix_gap, and fixes subdivisions for transposes of empty matrices of type matrix_mod2_dense, matrix_numpy_dense URL: sagemath#40423 Reported by: Biffo89 Reviewer(s): Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 29, 2025
sagemathgh-40423: Fix GF(2) matrix transpose with subdivisions <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. A small bug I noticed when looking at the code for transposing matrices. GF(2) does not properly transpose its subdivisions, meaning transposed matrices can have incorrect subdivisions or cause errors if the indices fall out of range. sage: M = matrix.random(GF(2),3,3) sage: N = matrix.block([[M,M,M]]) sage: M [1 0 0] [0 0 1] [0 1 0] sage: N [1 0 0|1 0 0|1 0 0] [0 0 1|0 0 1|0 0 1] [0 1 0|0 1 0|0 1 0] sage: N.transpose() <repr(<sage.matrix.matrix_mod2_dense.Matrix_mod2_dense at 0x7f1eb7f0c1c0>) failed: IndexError: list index out of range> This also adds subdivision handling to transposes of matrix_complex_ball_dense, matrix_gap, and fixes subdivisions for transposes of empty matrices of type matrix_mod2_dense, matrix_numpy_dense URL: sagemath#40423 Reported by: Biffo89 Reviewer(s): Xavier Caruso
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
A small bug I noticed when looking at the code for transposing matrices. GF(2) does not properly transpose its subdivisions, meaning transposed matrices can have incorrect subdivisions or cause errors if the indices fall out of range.
sage: M = matrix.random(GF(2),3,3)
sage: N = matrix.block([[M,M,M]])
sage: M
[1 0 0]
[0 0 1]
[0 1 0]
sage: N
[1 0 0|1 0 0|1 0 0]
[0 0 1|0 0 1|0 0 1]
[0 1 0|0 1 0|0 1 0]
sage: N.transpose()
<repr(<sage.matrix.matrix_mod2_dense.Matrix_mod2_dense at 0x7f1eb7f0c1c0>) failed: IndexError: list index out of range>
This also adds subdivision handling to transposes of matrix_complex_ball_dense, matrix_gap, and fixes subdivisions for transposes of empty matrices of type matrix_mod2_dense, matrix_numpy_dense