-
-
Notifications
You must be signed in to change notification settings - Fork 654
Method A-field for Drinfeld modules #40420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing tests are unrelated to this contribution. I accept the PR. |
kryzar
approved these changes
Jul 16, 2025
This was referenced Jul 17, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40420: Method A-field for Drinfeld modules We implement the method `A_field` for Drinfeld modules. It is a synonym of `base`; however, having it will be convenient when we implement Anderson motives (coming soon) since A-field and base ring are not the same in this case. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#40420 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 25, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the method
A_field
for Drinfeld modules.It is a synonym of
base
; however, having it will be convenient when we implement Anderson motives (coming soon) since A-field and base ring are not the same in this case.📝 Checklist