Skip to content

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Jul 16, 2025

We implement the method A_field for Drinfeld modules.
It is a synonym of base; however, having it will be convenient when we implement Anderson motives (coming soon) since A-field and base ring are not the same in this case.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@kryzar
Copy link
Contributor

kryzar commented Jul 16, 2025

The failing tests are unrelated to this contribution. I accept the PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 18, 2025
sagemathgh-40420: Method A-field for Drinfeld modules
    
We implement the method `A_field` for Drinfeld modules.
It is a synonym of `base`; however, having it will be convenient when we
implement Anderson motives (coming soon) since A-field and base ring are
not the same in this case.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#40420
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 18, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules
    
In the theory of Drinfeld module, the classical name of the
noncommutative variable is `τ`. However, in Sage, we currently use `t`,
which might conflict with other standard notations (often the variable
name of the underlying function ring is denoted by `t`).
In this PR, we propose to shift to the notation `τ`. It just changes how
the outputs are printed (by default), not the interface.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40420, sagemath#40421
    
URL: sagemath#40430
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
@vbraun vbraun merged commit c88a0e9 into sagemath:develop Jul 25, 2025
19 of 24 checks passed
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 12, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules
    
In the theory of Drinfeld module, the classical name of the
noncommutative variable is `τ`. However, in Sage, we currently use `t`,
which might conflict with other standard notations (often the variable
name of the underlying function ring is denoted by `t`).
In this PR, we propose to shift to the notation `τ`. It just changes how
the outputs are printed (by default), not the interface.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40420, sagemath#40421
    
URL: sagemath#40430
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 13, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules
    
In the theory of Drinfeld module, the classical name of the
noncommutative variable is `τ`. However, in Sage, we currently use `t`,
which might conflict with other standard notations (often the variable
name of the underlying function ring is denoted by `t`).
In this PR, we propose to shift to the notation `τ`. It just changes how
the outputs are printed (by default), not the interface.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40420, sagemath#40421
    
URL: sagemath#40430
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
@xcaruso xcaruso deleted the Afield branch August 19, 2025 16:41
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 21, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules
    
In the theory of Drinfeld module, the classical name of the
noncommutative variable is `τ`. However, in Sage, we currently use `t`,
which might conflict with other standard notations (often the variable
name of the underlying function ring is denoted by `t`).
In this PR, we propose to shift to the notation `τ`. It just changes how
the outputs are printed (by default), not the interface.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40420, sagemath#40421
    
URL: sagemath#40430
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 25, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules
    
In the theory of Drinfeld module, the classical name of the
noncommutative variable is `τ`. However, in Sage, we currently use `t`,
which might conflict with other standard notations (often the variable
name of the underlying function ring is denoted by `t`).
In this PR, we propose to shift to the notation `τ`. It just changes how
the outputs are printed (by default), not the interface.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40420, sagemath#40421
    
URL: sagemath#40430
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants