Replace 'sage-python' with 'python3' in various scripts for Meson #40490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the reason for doing it only for a few scripts? Why not just drop it completely? |
Good question ;-)
Done now. |
antonio-rojas
approved these changes
Jul 29, 2025
|
while it might be something that might break for Python built by Sage, I'll consider this a long overdue step towards removing the latter antique feature. |
dimpase
approved these changes
Jul 29, 2025
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 9, 2025
sagemathgh-40526: Delete one appearance of sage-python <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> In sagemath#40490, `sage-python` has been replaced by `python3` and one `bin/sage-python` has been erased, while other one is still there, erase it also. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40526 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Dima Pasechnik
|
This causes docbuild issues, see #40605 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a pure meson build there is no
sage-python, so scripts declaring usingsage-pythonare not working in this context. To remedy this, simplypython3is used instead.📝 Checklist
⌛ Dependencies