Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time gap_packages does not build with gcc-15 due at list to a problem with semigroups packages. It seems that clang-17 has also similar issues, see https://groups.google.com/g/sage-release/c/ECrJI6ZiUmQ.
There are some modifications coming from #39977 and fedora rpms:
spkg-install.in
of:Not neededgap
: to be checked if it is needed.gap_packages
: there may be a more elegant modificationNot neededplanarity
: to be checked if it is needed.Not neededsagelib
: to be checked if it is needed.build/pkgs/gap_packages/patches
(the patch for clang-17 did not work for me, this can be an issue)There is another point concerning
gap_packages
. I wonder if it is better to have separated packages; now the failure in one package prevents the installation of the whole spkg.📝 Checklist
⌛ Dependencies