src/sage/combinat/rsk.py: shorter long tests #40476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run. Test 1: 2025-07-24T02:15:48.3913655Z ##[warning]slow doctest: 2025-07-24T02:15:48.3915925Z for T in FC_tabs: # long time ... 2025-07-24T02:15:48.3919438Z Test ran for 35.12s cpu, 35.24s wall 2025-07-24T02:15:48.3919823Z Check ran for 0.00s cpu, 0.00s wall Test 2: 2025-07-24T02:16:49.7199852Z ##[warning]slow doctest: 2025-07-24T02:16:49.7203007Z for T in FC_tabs: # long time ... 2025-07-24T02:16:49.7206924Z Test ran for 61.00s cpu, 61.33s wall 2025-07-24T02:16:49.7207363Z Check ran for 0.00s cpu, 0.00s wall (Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs.
|
looks reasonable to me. It might be even better to test on a large random tableau ( |
|
Thanks. The |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run. Test 1: ``` 2025-07-24T02:15:48.3913655Z ##[warning]slow doctest: 2025-07-24T02:15:48.3915925Z for T in FC_tabs: # long time 2025-07-24T02:15:48.3916340Z shape = T.shape().conjugate() 2025-07-24T02:15:48.3916739Z P = T.conjugate() 2025-07-24T02:15:48.3917158Z Checks += [all((P,Q) == tuple(RSK(*RSK_inverse(P, Q, 2025-07-24T02:15:48.3917710Z insertion='Star', output='array'), 2025-07-24T02:15:48.3918480Z insertion='Star')) 2025-07-24T02:15:48.3918950Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:15:48.3919438Z Test ran for 35.12s cpu, 35.24s wall 2025-07-24T02:15:48.3919823Z Check ran for 0.00s cpu, 0.00s wall ``` Test 2: ``` 2025-07-24T02:16:49.7199852Z ##[warning]slow doctest: 2025-07-24T02:16:49.7203007Z for T in FC_tabs: # long time 2025-07-24T02:16:49.7203451Z shape = T.shape().conjugate() 2025-07-24T02:16:49.7203877Z P = T.conjugate() 2025-07-24T02:16:49.7204303Z Checks += [all((P,Q) == tuple(RSK(RSK_inverse(P, Q, 2025-07-24T02:16:49.7205293Z insertion='Star', output='DecreasingHeckeFactorization'), 2025-07-24T02:16:49.7205869Z insertion='Star')) 2025-07-24T02:16:49.7206370Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:16:49.7206924Z Test ran for 61.00s cpu, 61.33s wall 2025-07-24T02:16:49.7207363Z Check ran for 0.00s cpu, 0.00s wall ``` (Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs. URL: sagemath#40476 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40476: src/sage/combinat/rsk.py: shorter long tests Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run. Test 1: ``` 2025-07-24T02:15:48.3913655Z ##[warning]slow doctest: 2025-07-24T02:15:48.3915925Z for T in FC_tabs: # long time 2025-07-24T02:15:48.3916340Z shape = T.shape().conjugate() 2025-07-24T02:15:48.3916739Z P = T.conjugate() 2025-07-24T02:15:48.3917158Z Checks += [all((P,Q) == tuple(RSK(*RSK_inverse(P, Q, 2025-07-24T02:15:48.3917710Z insertion='Star', output='array'), 2025-07-24T02:15:48.3918480Z insertion='Star')) 2025-07-24T02:15:48.3918950Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:15:48.3919438Z Test ran for 35.12s cpu, 35.24s wall 2025-07-24T02:15:48.3919823Z Check ran for 0.00s cpu, 0.00s wall ``` Test 2: ``` 2025-07-24T02:16:49.7199852Z ##[warning]slow doctest: 2025-07-24T02:16:49.7203007Z for T in FC_tabs: # long time 2025-07-24T02:16:49.7203451Z shape = T.shape().conjugate() 2025-07-24T02:16:49.7203877Z P = T.conjugate() 2025-07-24T02:16:49.7204303Z Checks += [all((P,Q) == tuple(RSK(RSK_inverse(P, Q, 2025-07-24T02:16:49.7205293Z insertion='Star', output='DecreasingHeckeFactorization'), 2025-07-24T02:16:49.7205869Z insertion='Star')) 2025-07-24T02:16:49.7206370Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:16:49.7206924Z Test ran for 61.00s cpu, 61.33s wall 2025-07-24T02:16:49.7207363Z Check ran for 0.00s cpu, 0.00s wall ``` (Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs. URL: sagemath#40476 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 27, 2025
sagemathgh-40476: src/sage/combinat/rsk.py: shorter long tests Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run. Test 1: ``` 2025-07-24T02:15:48.3913655Z ##[warning]slow doctest: 2025-07-24T02:15:48.3915925Z for T in FC_tabs: # long time 2025-07-24T02:15:48.3916340Z shape = T.shape().conjugate() 2025-07-24T02:15:48.3916739Z P = T.conjugate() 2025-07-24T02:15:48.3917158Z Checks += [all((P,Q) == tuple(RSK(*RSK_inverse(P, Q, 2025-07-24T02:15:48.3917710Z insertion='Star', output='array'), 2025-07-24T02:15:48.3918480Z insertion='Star')) 2025-07-24T02:15:48.3918950Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:15:48.3919438Z Test ran for 35.12s cpu, 35.24s wall 2025-07-24T02:15:48.3919823Z Check ran for 0.00s cpu, 0.00s wall ``` Test 2: ``` 2025-07-24T02:16:49.7199852Z ##[warning]slow doctest: 2025-07-24T02:16:49.7203007Z for T in FC_tabs: # long time 2025-07-24T02:16:49.7203451Z shape = T.shape().conjugate() 2025-07-24T02:16:49.7203877Z P = T.conjugate() 2025-07-24T02:16:49.7204303Z Checks += [all((P,Q) == tuple(RSK(RSK_inverse(P, Q, 2025-07-24T02:16:49.7205293Z insertion='Star', output='DecreasingHeckeFactorization'), 2025-07-24T02:16:49.7205869Z insertion='Star')) 2025-07-24T02:16:49.7206370Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:16:49.7206924Z Test ran for 61.00s cpu, 61.33s wall 2025-07-24T02:16:49.7207363Z Check ran for 0.00s cpu, 0.00s wall ``` (Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs. URL: sagemath#40476 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 28, 2025
sagemathgh-40476: src/sage/combinat/rsk.py: shorter long tests Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run. Test 1: ``` 2025-07-24T02:15:48.3913655Z ##[warning]slow doctest: 2025-07-24T02:15:48.3915925Z for T in FC_tabs: # long time 2025-07-24T02:15:48.3916340Z shape = T.shape().conjugate() 2025-07-24T02:15:48.3916739Z P = T.conjugate() 2025-07-24T02:15:48.3917158Z Checks += [all((P,Q) == tuple(RSK(*RSK_inverse(P, Q, 2025-07-24T02:15:48.3917710Z insertion='Star', output='array'), 2025-07-24T02:15:48.3918480Z insertion='Star')) 2025-07-24T02:15:48.3918950Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:15:48.3919438Z Test ran for 35.12s cpu, 35.24s wall 2025-07-24T02:15:48.3919823Z Check ran for 0.00s cpu, 0.00s wall ``` Test 2: ``` 2025-07-24T02:16:49.7199852Z ##[warning]slow doctest: 2025-07-24T02:16:49.7203007Z for T in FC_tabs: # long time 2025-07-24T02:16:49.7203451Z shape = T.shape().conjugate() 2025-07-24T02:16:49.7203877Z P = T.conjugate() 2025-07-24T02:16:49.7204303Z Checks += [all((P,Q) == tuple(RSK(RSK_inverse(P, Q, 2025-07-24T02:16:49.7205293Z insertion='Star', output='DecreasingHeckeFactorization'), 2025-07-24T02:16:49.7205869Z insertion='Star')) 2025-07-24T02:16:49.7206370Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:16:49.7206924Z Test ran for 61.00s cpu, 61.33s wall 2025-07-24T02:16:49.7207363Z Check ran for 0.00s cpu, 0.00s wall ``` (Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs. URL: sagemath#40476 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 29, 2025
sagemathgh-40476: src/sage/combinat/rsk.py: shorter long tests Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run. Test 1: ``` 2025-07-24T02:15:48.3913655Z ##[warning]slow doctest: 2025-07-24T02:15:48.3915925Z for T in FC_tabs: # long time 2025-07-24T02:15:48.3916340Z shape = T.shape().conjugate() 2025-07-24T02:15:48.3916739Z P = T.conjugate() 2025-07-24T02:15:48.3917158Z Checks += [all((P,Q) == tuple(RSK(*RSK_inverse(P, Q, 2025-07-24T02:15:48.3917710Z insertion='Star', output='array'), 2025-07-24T02:15:48.3918480Z insertion='Star')) 2025-07-24T02:15:48.3918950Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:15:48.3919438Z Test ran for 35.12s cpu, 35.24s wall 2025-07-24T02:15:48.3919823Z Check ran for 0.00s cpu, 0.00s wall ``` Test 2: ``` 2025-07-24T02:16:49.7199852Z ##[warning]slow doctest: 2025-07-24T02:16:49.7203007Z for T in FC_tabs: # long time 2025-07-24T02:16:49.7203451Z shape = T.shape().conjugate() 2025-07-24T02:16:49.7203877Z P = T.conjugate() 2025-07-24T02:16:49.7204303Z Checks += [all((P,Q) == tuple(RSK(RSK_inverse(P, Q, 2025-07-24T02:16:49.7205293Z insertion='Star', output='DecreasingHeckeFactorization'), 2025-07-24T02:16:49.7205869Z insertion='Star')) 2025-07-24T02:16:49.7206370Z for Q in SemistandardTableaux(shape, max_entry=5))] 2025-07-24T02:16:49.7206924Z Test ran for 61.00s cpu, 61.33s wall 2025-07-24T02:16:49.7207363Z Check ran for 0.00s cpu, 0.00s wall ``` (Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs. URL: sagemath#40476 Reported by: Michael Orlitzky Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests in this file are checking that RSK and RSK_inverse are in fact inverses on a (length 621) subset of the semistandard tableaux, but they are taking a long time to run.
Test 1:
Test 2:
(Here, FC_tabs is the subset of the tableaux.) Rather than check all of these, we can instead test a random subset. This commit checks only 25 of them at a time to speed up the test runs.