-
-
Notifications
You must be signed in to change notification settings - Fork 648
Add pytest command to run tests in CI workflow #40474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What's the issue with the deleted test? |
The The tests are more or less outdated/not very important. |
I'd rather be careful and do a |
With #39030 there is only going to be a meson build... |
Is |
Good observation. It's no longer used, indeed, and thus I've removed it now as well. |
Tobias is the one who added these tests, so "they're not very important" is a more compelling argument than usual. In the near future we will (want to) be able to tell people to run |
Not related, but is it intended that the Meson/Windows jobs are passing even though the test phase fails? |
FWIW there's no way to test for meson per se, but there are several variables that are meaningless outside of sage-the-distro and are usually unset (distro packages tend to have similar problems). |
Thanks for the review!
Yes, as we don't have any meaningful way to run the tests on Windows now (in a way that make most of them pass). The important part is that the compilation is successful on Win.
With #39030, sage-the-distro will also finally use the meson backend. Afterwards we can indeed remove all those special variables, and also determine features during build time and not runtime. |
Alternative to #40446. This time running pytest directly in the CI, instead of as part of
sage -t
.Removed one old test file that fails with meson since the sage cli is different then.
📝 Checklist
⌛ Dependencies