src/sage/symbolic/random_tests.py: fewer random test repetitions #40472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently run sage: check_symbolic_expression_order(200) sage: check_symbolic_expression_order(10000) # long time in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI: 2025-07-24T02:19:27.8495248Z ##[warning]slow doctest: 2025-07-24T02:19:27.8496718Z check_symbolic_expression_order(10000) 2025-07-24T02:19:27.8497325Z Test ran for 34.32s cpu, 34.36s wall 2025-07-24T02:19:27.8498929Z Check ran for 0.00s cpu, 0.00s wall This commit combines the two lines into a single test, sage: check_symbolic_expression_order(500) # long time to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes.
974f59d to
4fc99c0
Compare
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40472: src/sage/symbolic/random_tests.py: fewer random test repetitions We currently run ``` sage: check_symbolic_expression_order(200) sage: check_symbolic_expression_order(10000) # long time ``` in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI: ``` 2025-07-24T02:19:27.8495248Z ##[warning]slow doctest: 2025-07-24T02:19:27.8496718Z check_symbolic_expression_order(10000) 2025-07-24T02:19:27.8497325Z Test ran for 34.32s cpu, 34.36s wall 2025-07-24T02:19:27.8498929Z Check ran for 0.00s cpu, 0.00s wall ``` This commit combines the two lines into a single test, ``` sage: check_symbolic_expression_order(500) # long time ``` to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes. URL: sagemath#40472 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 26, 2025
sagemathgh-40472: src/sage/symbolic/random_tests.py: fewer random test repetitions We currently run ``` sage: check_symbolic_expression_order(200) sage: check_symbolic_expression_order(10000) # long time ``` in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI: ``` 2025-07-24T02:19:27.8495248Z ##[warning]slow doctest: 2025-07-24T02:19:27.8496718Z check_symbolic_expression_order(10000) 2025-07-24T02:19:27.8497325Z Test ran for 34.32s cpu, 34.36s wall 2025-07-24T02:19:27.8498929Z Check ran for 0.00s cpu, 0.00s wall ``` This commit combines the two lines into a single test, ``` sage: check_symbolic_expression_order(500) # long time ``` to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes. URL: sagemath#40472 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 27, 2025
sagemathgh-40472: src/sage/symbolic/random_tests.py: fewer random test repetitions We currently run ``` sage: check_symbolic_expression_order(200) sage: check_symbolic_expression_order(10000) # long time ``` in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI: ``` 2025-07-24T02:19:27.8495248Z ##[warning]slow doctest: 2025-07-24T02:19:27.8496718Z check_symbolic_expression_order(10000) 2025-07-24T02:19:27.8497325Z Test ran for 34.32s cpu, 34.36s wall 2025-07-24T02:19:27.8498929Z Check ran for 0.00s cpu, 0.00s wall ``` This commit combines the two lines into a single test, ``` sage: check_symbolic_expression_order(500) # long time ``` to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes. URL: sagemath#40472 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 28, 2025
sagemathgh-40472: src/sage/symbolic/random_tests.py: fewer random test repetitions We currently run ``` sage: check_symbolic_expression_order(200) sage: check_symbolic_expression_order(10000) # long time ``` in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI: ``` 2025-07-24T02:19:27.8495248Z ##[warning]slow doctest: 2025-07-24T02:19:27.8496718Z check_symbolic_expression_order(10000) 2025-07-24T02:19:27.8497325Z Test ran for 34.32s cpu, 34.36s wall 2025-07-24T02:19:27.8498929Z Check ran for 0.00s cpu, 0.00s wall ``` This commit combines the two lines into a single test, ``` sage: check_symbolic_expression_order(500) # long time ``` to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes. URL: sagemath#40472 Reported by: Michael Orlitzky Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 29, 2025
sagemathgh-40472: src/sage/symbolic/random_tests.py: fewer random test repetitions We currently run ``` sage: check_symbolic_expression_order(200) sage: check_symbolic_expression_order(10000) # long time ``` in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI: ``` 2025-07-24T02:19:27.8495248Z ##[warning]slow doctest: 2025-07-24T02:19:27.8496718Z check_symbolic_expression_order(10000) 2025-07-24T02:19:27.8497325Z Test ran for 34.32s cpu, 34.36s wall 2025-07-24T02:19:27.8498929Z Check ran for 0.00s cpu, 0.00s wall ``` This commit combines the two lines into a single test, ``` sage: check_symbolic_expression_order(500) # long time ``` to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes. URL: sagemath#40472 Reported by: Michael Orlitzky Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently run
in succession, for a total of 10200 total repetitions of this random test. The second one is slow and is raising warnings in the CI:
This commit combines the two lines into a single test,
to eliminate the warning. We run these tests on every pull request, so if there is a problem, we will catch it eventually, even with fewer repetitions per run. And anyone messing with the ordering on SR can of course run the tests with as many repetitions as he likes.