Skip to content

fix a doctest error in src/sage/interfaces/polymake.py #40462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2025
Merged

fix a doctest error in src/sage/interfaces/polymake.py #40462

merged 2 commits into from
Aug 2, 2025

Conversation

cxzhong
Copy link
Contributor

@cxzhong cxzhong commented Jul 21, 2025

Fixes #40461, Fixes an doctest error in polymake.py

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#40461

@cxzhong
Copy link
Contributor Author

cxzhong commented Jul 21, 2025 •
edited
Loading

Now It passed the tests

./sage -t --warn-long 5.0 --random-seed=233797780117811162927400537850871848271 src/sage/interfaces/polymake.py
Running doctests with ID 2025-07-21-14-45-14-696aab3b.
Git branch: develop
Git ref: 10.7.beta8-dirty
Running with SAGE_LOCAL='/home/zhongcx/sage/local' and SAGE_VENV='/home/zhongcx/sage/local/var/lib/sage/venv-python3.13'
Using --optional=4ti2,debian,e_antic,fricas,giac,jupymake,latte_int,lidia,msolve,normaliz,pip,sage,sage_spkg
Features to be detected: 4ti2,SAGE_SRC,benzene,bliss,buckygen,conway_polynomials,coxeter3,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_ellcurves,database_graphs,database_jones_numfield,database_knotinfo,dot2tex,dvipng,ecm,flatter,fpylll,fricas,gap_package_atlasrep,gap_package_design,gap_package_grape,gap_package_guava,gap_package_hap,gap_package_polenta,gap_package_polycyclic,gap_package_qpa,gap_package_quagroup,gfan,giac,glucose,graphviz,imagemagick,info,ipython,jmol,jupymake,jupyter_sphinx,kenzo,kissat,latte_int,lrcalc_python,lrslib,mathics,matroid_database,mcqd,meataxe,meson_editable,mpmath,msolve,nauty,networkx,numpy,palp,pandoc,pdf2svg,pdftocairo,pexpect,phitigra,pillow,plantri,polytopes_db,polytopes_db_4d,pplpy,primecountpy,ptyprocess,pycosat,pycryptosat,pynormaliz,pyparsing,python_igraph,requests,rpy2,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.braiding,sage.libs.ecl,sage.libs.flint,sage.libs.gap,sage.libs.giac,sage.libs.homfly,sage.libs.linbox,sage.libs.m4ri,sage.libs.ntl,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modular,sage.modules,sage.numerical.mip,sage.plot,sage.rings.complex_double,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.polynomial.pbori,sage.rings.real_double,sage.rings.real_mpfr,sage.sat,sage.schemes,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,scipy,singular,sirocco,sloane_database,sphinx,symengine_py,sympy,tdlib,threejs,topcom
Doctesting 1 file.
sage -t --warn-long 5.0 --random-seed=233797780117811162927400537850871848271 src/sage/interfaces/polymake.py
    [258 tests, 2.11s wall]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 2.1 seconds
    cpu time: 1.7 seconds
    cumulative wall time: 2.1 seconds
Features detected for doctesting:

fchapoton
fchapoton reviewed Jul 21, 2025
View reviewed changes
@cxzhong cxzhong requested a review from fchapoton July 21, 2025 13:00
@cxzhong cxzhong changed the title fix an doctest error in src/sage/interfaces/polymake.py fix a doctest error in src/sage/interfaces/polymake.py Jul 21, 2025
fchapoton
fchapoton approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, maybe

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 26, 2025
e92fa46 
sagemathgh-40462: fix a doctest error in src/sage/interfaces/polymake.py
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#40461, Fixes an doctest error in  polymake.py


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->sagemath#40461
    
URL: sagemath#40462
Reported by: Chenxin Zhong
Reviewer(s): Chenxin Zhong, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 26, 2025
17eb13e 
sagemathgh-40462: fix a doctest error in src/sage/interfaces/polymake.py
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#40461, Fixes an doctest error in  polymake.py


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->sagemath#40461
    
URL: sagemath#40462
Reported by: Chenxin Zhong
Reviewer(s): Chenxin Zhong, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 27, 2025
83784b2 
sagemathgh-40462: fix a doctest error in src/sage/interfaces/polymake.py
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#40461, Fixes an doctest error in  polymake.py


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->sagemath#40461
    
URL: sagemath#40462
Reported by: Chenxin Zhong
Reviewer(s): Chenxin Zhong, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 28, 2025
d380a5e 
sagemathgh-40462: fix a doctest error in src/sage/interfaces/polymake.py
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#40461, Fixes an doctest error in  polymake.py


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->sagemath#40461
    
URL: sagemath#40462
Reported by: Chenxin Zhong
Reviewer(s): Chenxin Zhong, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 29, 2025
5d5363a 
sagemathgh-40462: fix a doctest error in src/sage/interfaces/polymake.py
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#40461, Fixes an doctest error in  polymake.py


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->sagemath#40461
    
URL: sagemath#40462
Reported by: Chenxin Zhong
Reviewer(s): Chenxin Zhong, Frédéric Chapoton
@vbraun vbraun merged commit 84cc006 into sagemath:develop Aug 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

an doctest error in src/sage/interfaces/polymake.py
3 participants
@cxzhong @fchapoton @vbraun