Skip to content

Update to zlib 1.3.1 #40445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Update to zlib 1.3.1 #40445

merged 1 commit into from
Jul 25, 2025

Conversation

vbraun
Copy link
Member

@vbraun vbraun commented Jul 18, 2025 •
edited
Loading

zlib-1.2.11fails to build on macos 15 Sequoia with

[spkg-install] gcc -g -O2 -DHAVE_HIDDEN  -c -o zutil.o zutil.c
[spkg-install] In file included from zutil.c:8:
[spkg-install] ./zutil.h:163:11: warning: 'OS_CODE' macro redefined [-Wmacro-redefined]
[spkg-install]   163 | #  define OS_CODE 19
[spkg-install]       |           ^
[spkg-install] ./zutil.h:134:11: note: previous definition is here
[spkg-install]   134 | #  define OS_CODE  7
[spkg-install]       |           ^
[spkg-install] In file included from zutil.c:10:
[spkg-install] In file included from ./gzguts.h:21:
[spkg-install] In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:61:
[spkg-install] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/_stdio.h:318:7: error: expected identifier or '('

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 18, 2025
sagemathgh-40445: Update to zlib 1.3.1
c73a3c2 
URL: sagemath#40445
Reported by: Volker Braun
Reviewer(s):
@orlitzky
Copy link
Contributor

This probably only gets used on macos anyway, so here is a rubber stamp.

@dimpase
Copy link
Member

dimpase commented Jul 21, 2025

we should just get rid of this spkg. Please review #40460

@vbraun vbraun merged commit a1fb267 into sagemath:develop Jul 25, 2025
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: blocker / 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbraun @orlitzky @dimpase