Skip to content

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Jul 18, 2025

We implement a method for computing a basis of the homset between two Drinfeld modules defined over a finite field.

Includes #35386

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#40430, #40436

@xcaruso xcaruso requested a review from kryzar July 18, 2025 08:53
@xcaruso xcaruso changed the title Morphisms between Drinfeld modules Hom spaces between Drinfeld modules Jul 18, 2025
@kryzar
Copy link
Contributor

kryzar commented Jul 18, 2025

Perhaps we should add Joseph's thesis in the references as well?

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 14, 2025
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixed an atrocious typo in the description of the
`frobenius_endomorphism` method of the class `DrinfeldModule_finite`.

I followed the notation (the degree of `K` over `\mathbb F_q` is denoted
by `n`) chosen by Xavier @xcaruso in his PR on homsets of Drinfeld
modules (sagemath#40440).

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

None.

URL: sagemath#40575
Reported by: Antoine Leudière
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 14, 2025
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixed an atrocious typo in the description of the
`frobenius_endomorphism` method of the class `DrinfeldModule_finite`.

I followed the notation (the degree of `K` over `\mathbb F_q` is denoted
by `n`) chosen by Xavier @xcaruso in his PR on homsets of Drinfeld
modules (sagemath#40440).

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

None.

URL: sagemath#40575
Reported by: Antoine Leudière
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 16, 2025
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Fixed an atrocious typo in the description of the
`frobenius_endomorphism` method of the class `DrinfeldModule_finite`.

I followed the notation (the degree of `K` over `\mathbb F_q` is denoted
by `n`) chosen by Xavier @xcaruso in his PR on homsets of Drinfeld
modules (sagemath#40440).

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

None.

URL: sagemath#40575
Reported by: Antoine Leudière
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 21, 2025
sagemathgh-40440: Hom spaces between Drinfeld modules
    
We implement a method for computing a basis of the homset between two
Drinfeld modules defined over a finite field.

Includes sagemath#35386

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40430, sagemath#40436
    
URL: sagemath#40440
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière, Xavier Caruso
@vbraun vbraun merged commit e808bd9 into sagemath:develop Aug 27, 2025
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants