Skip to content

Fix lint #40309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2025
Merged

Fix lint #40309

merged 1 commit into from
Jul 6, 2025

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Jun 26, 2025 •
edited
Loading

Fix lint failure introduced in #39920 . Strangely, https://github.com/sagemath/sage/actions/runs/15639025083/job/44061585299 had no failure.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 added the p: CI Fix merged before running CI tests label Jun 26, 2025
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit ace69a4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

fchapoton
fchapoton approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 27, 2025
b54d59c 
sagemathgh-40309: Fix lint
    
Fix lint failure introduced in
sagemath#39920 . Strangely, https://github.
com/sagemath/sage/actions/runs/15639025083/job/44061585299 had no
failure.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40309
Reported by: user202729
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit a549049 into sagemath:develop Jul 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
p: CI Fix merged before running CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@user202729 @fchapoton @vbraun