Fix lint #40385
Merged
Fix lint #40385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
reviewed
Jul 7, 2025
| @@ -298,7 +298,7 @@ def image_coordinates(self, x): | |||
| sage: phi.image_coordinates(-I) | |||
| 0 | |||
|
|
|||
| TESTS:: | |||
| TESTS: | |||
There was a problem hiding this comment.
This change looks strange. Isn't TESTS:: the standard way?
There was a problem hiding this comment.
in RST :: denotes following code block. So we have
TESTS::
sage: something
or
TESTS:
Some explanation::
sage: something
in the latter case there's no :: following TESTS.
While Sage considers TESTS a magic keyword, RST doesn't.
There was a problem hiding this comment.
Ah ok, thanks for the clarification.
Usually because the failing linter was ignored or because the linter rules were made more strict, but another PR broke the stricter rules and was merged at the same time. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 14, 2025
sagemathgh-40385: Fix lint Any idea why lint keeps failing? Unexpected ruff version? (how does `uv` determine the version? @tobiasdiez ? ) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40385 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-40385: Fix lint Any idea why lint keeps failing? Unexpected ruff version? (how does `uv` determine the version? @tobiasdiez ? ) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40385 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any idea why lint keeps failing? Unexpected ruff version? (how does
uvdetermine the version? @tobiasdiez ? )📝 Checklist
⌛ Dependencies