Skip to content

Conversation

tobiasdiez
Copy link
Contributor

Docbuilding is done in a seperate CI workflow, so there is no need to also build the docs as part of the normal CI runs.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jul 1, 2025

Documentation preview for this PR (built with commit 89a90ba; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez requested a review from dimpase July 1, 2025 22:09
@dimpase
Copy link
Member

dimpase commented Jul 1, 2025

is this CI failure: https://github.com/sagemath/sage/actions/runs/16010353194/job/45166596720?pr=40357
a result of this PR?

@tobiasdiez
Copy link
Contributor Author

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@vbraun vbraun merged commit 25fc6f0 into sagemath:develop Jul 6, 2025
35 of 38 checks passed
@tobiasdiez tobiasdiez deleted the ci-remove-dupl-docbuild branch July 7, 2025 11:43
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 1, 2025
sagemathgh-40341: Set cython directive `binding=True`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Continuation of sagemath#26254. This is needed for better integration of Cython
functions and thereby unlocks a few further documentation improvements
(sagemath#27578, sagemath#30884, sagemath#31309, ...).

Moreover, `binding=True` is the default in Cython 3.

### 📝 Checklist


<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

- sagemath#40357
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40341
Reported by: Tobias Diez
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants