Skip to content

Improve signal handling on Windows in doctest reporting module #40232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

Improve signal handling on Windows in doctest reporting module #40232

merged 3 commits into from
Jul 6, 2025

Conversation

tobiasdiez
Copy link
Contributor

Conditionally import a few signals which don't exist on Windows.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 387ffdb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez requested a review from dimpase June 15, 2025 18:54
dimpase
dimpase approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tobiasdiez
Copy link
Contributor Author

Thanks!

@vbraun vbraun merged commit 62b611d into sagemath:develop Jul 6, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dimpase dimpase dimpase approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: doctest framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasdiez @dimpase @vbraun