Skip to content

add checks to the linter once again #40208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025
Merged

Conversation

fchapoton
Copy link
Contributor

follow up of #40122

about using ruff to check code formatting in the lint CI

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton requested a review from tobiasdiez June 4, 2025 18:25
@fchapoton
Copy link
Contributor Author

@tobiasdiez : ready for review, I hope

Copy link

github-actions bot commented Jun 4, 2025

Documentation preview for this PR (built with commit 79b4737; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should have caught it in the other PR.

Should we remove the config in the tox files? It seems very redundant and only adds to the maintenance burden. The "maximal" ruff config is also specified in the pyproject.toml file in the root.

@fchapoton
Copy link
Contributor Author

fchapoton commented Jun 5, 2025

should we add that to the CI-fix tag ?

@fchapoton fchapoton added the p: CI Fix merged before running CI tests label Jun 5, 2025
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 6, 2025
follow up of sagemath#40122

about using ruff to check code formatting in the lint CI

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: sagemath#40208
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 8, 2025
sagemathgh-40208: add checks to the linter once again
    
follow up of sagemath#40122

about using ruff to check code formatting in the lint CI

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40208
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
sagemathgh-40208: add checks to the linter once again
    
follow up of sagemath#40122

about using ruff to check code formatting in the lint CI

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40208
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
sagemathgh-40208: add checks to the linter once again
    
follow up of sagemath#40122

about using ruff to check code formatting in the lint CI

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40208
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
sagemathgh-40208: add checks to the linter once again
    
follow up of sagemath#40122

about using ruff to check code formatting in the lint CI

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40208
Reported by: Frédéric Chapoton
Reviewer(s): Tobias Diez
@vbraun vbraun merged commit 693eac4 into sagemath:develop Jun 14, 2025
24 of 25 checks passed
@fchapoton fchapoton deleted the ruff_lint_more branch June 15, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: CI Fix merged before running CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants