Remove pkgconf spkg #40204
Remove pkgconf spkg #40204
Conversation
|
Documentation preview for this PR (built with commit f48be88; changes) is ready! 🎉 |
|
CI runs for full coverage: |
|
right, the planarity thing comes from the fact that I cannot build Sage without it - it's from a positively reviewed PR #40153 which should be in the coming beta. I forgot to list it in the deps, done now. |
long overdue - also, supports gcc-15 out of the box
removed compile checks, as they were testing for a very old planarity version, and keeping it needs figuring out the header version to use.
ae8e869 to
fc407a4
Compare
|
fixed a typo leading to docbuild - should be OK now (it builds locally) |
|
Small nitpick: the CI https://github.com/sagemath/sage/actions/runs/15716873483/job/44288781941?pr=40204#step:11:497 complains about
I think these flags come from Line 50 in 11baeed If this is something that could be fixed easily, I would prefer if its done as part of this PR - if not, also no biggy. |
|
@tobiasdiez are these not coming from a previous generation of a docker image, and would go away in the next beta? I tried to see where |
|
Sounds reasonable. It's sad that you cannot really trust the CI 🙄. Thanks for checking though! |
sagemathgh-40204: Remove pkgconf spkg `pkgconf`, a.k.a. `pkg-config`, is available on all systems we support - even on the "naked" (no homebrew/macports) macOS one can install a formally certified/notarised package https://github.com/donmccaughey/pkg-config_pkg - so there is no reason to keep it in the tree. There are big advantages to have pkg-config available at configure time, as recognition of several crucial external spkgs, such as (open)blas, zlib, etc. hinges upon pkg-config. With this PR in, we proceed to remove them. Last but not the least, it simplifies the Makefile by getting rid of `base` target, which becomes empty ## 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40011 - remove bzip2 spkg. - sagemath#40153 - planarity spkg fix (can't build otherwise) URL: sagemath#40204 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, Tobias Diez
pkgconf, a.k.a.pkg-config, is available on all systems we support - even on the "naked" (no homebrew/macports) macOS one can install a formally certified/notarised package https://github.com/donmccaughey/pkg-config_pkg - so there is no reason to keep it in the tree.There are big advantages to have pkg-config available at configure time, as recognition of several crucial external spkgs, such as (open)blas, zlib, etc. hinges upon pkg-config.
With this PR in, we proceed to remove them.
Last but not the least, it simplifies the Makefile by getting rid of
basetarget, which becomes empty📝 Checklist
⌛ Dependencies