-
-
Notifications
You must be signed in to change notification settings - Fork 652
Fix a bug in khuri-makdisi small model #40240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug in khuri-makdisi small model #40240
Conversation
8344016
to
af7d348
Compare
Documentation preview for this PR (built with commit 2d2592d; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Requesting two small changes to the doctest.
I think I need a bit of help/context to understand what's going on here before I can approve this (I've only glanced at Khuri-Makdisi's paper so I'm not very familiar with how the algorithm works). Can you explain a bit more (just in GitHub, you don't need to add the explanation to the code unless you think it's necessary) about what's going on at this part of the code/what was causing this bug and why this (correctly) fixes it?
As the added comment says
we cannot guarantee the dimension of |
Thanks! |
Fixes #40237.
📝 Checklist
⌛ Dependencies