-
-
Notifications
You must be signed in to change notification settings - Fork 654
Translate constructions docs into Chinese #40139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot verify that there are no typos/mistranslations in the Chinese, but I was hoping we could get rid of some old stuff in the new files:
.. math::
->.. MATH::
:math:`foo`
->`foo`
Let's not make the problem worse. ;)
I will clean up all old style notations in the documentation. |
@tscrim I have replaced I'm wondering if it would be appropriate to replace all old style notations in historical documents and translated documents with standard notations. |
Yes, that would be a good PR, but it should be done separately from this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have missed a few other analogous changes in the added files. I'd appreciate it if you could check (again) as well.
Documentation preview for this PR (built with commit b0c6b79; changes) is ready! 🎉 |
@tscrim Based on your suggestions, I have optimized and fixed all formatting issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you've visually with some font formatting on spacing made the lengths match, but not in a monospaced font I think. Well, I don't think it is that important. Let's get this into the next version of SageMath. Thank you.
sagemathgh-40139: Translate constructions docs into Chinese * Translate constructions docs into Chinese * Fix some typos ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions. URL: sagemath#40139 Reported by: Fisher Reviewer(s): Fisher, Travis Scrimshaw
sagemathgh-40139: Translate constructions docs into Chinese * Translate constructions docs into Chinese * Fix some typos ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions. URL: sagemath#40139 Reported by: Fisher Reviewer(s): Fisher, Travis Scrimshaw
sagemathgh-40139: Translate constructions docs into Chinese * Translate constructions docs into Chinese * Fix some typos ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions. URL: sagemath#40139 Reported by: Fisher Reviewer(s): Fisher, Travis Scrimshaw
sagemathgh-40139: Translate constructions docs into Chinese * Translate constructions docs into Chinese * Fix some typos ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions. URL: sagemath#40139 Reported by: Fisher Reviewer(s): Fisher, Travis Scrimshaw
sagemathgh-40139: Translate constructions docs into Chinese * Translate constructions docs into Chinese * Fix some typos ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions. URL: sagemath#40139 Reported by: Fisher Reviewer(s): Fisher, Travis Scrimshaw
Should this be closed or not? |
📝 Checklist
⌛ Dependencies
Follow PR #40049, Replace dead HTTP links in tutorial & constructions.