Skip to content

Conversation

fisheryv
Copy link
Contributor

  • Translate constructions docs into Chinese
  • Fix some typos

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Follow PR #40049, Replace dead HTTP links in tutorial & constructions.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot verify that there are no typos/mistranslations in the Chinese, but I was hoping we could get rid of some old stuff in the new files:

  • .. math:: -> .. MATH::
  • :math:`foo` -> `foo`

Let's not make the problem worse. ;)

@fisheryv
Copy link
Contributor Author

fisheryv commented May 28, 2025

I will clean up all old style notations in the documentation.

@fisheryv
Copy link
Contributor Author

fisheryv commented May 29, 2025

@tscrim I have replaced .. math:: with .. MATH:: and replaced :math:`foo` with `foo`.

I'm wondering if it would be appropriate to replace all old style notations in historical documents and translated documents with standard notations.

@tscrim
Copy link
Collaborator

tscrim commented May 29, 2025

Yes, that would be a good PR, but it should be done separately from this one.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed a few other analogous changes in the added files. I'd appreciate it if you could check (again) as well.

Copy link

github-actions bot commented Jun 25, 2025

Documentation preview for this PR (built with commit b0c6b79; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fisheryv
Copy link
Contributor Author

fisheryv commented Aug 5, 2025

@tscrim Based on your suggestions, I have optimized and fixed all formatting issues.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you've visually with some font formatting on spacing made the lengths match, but not in a monospaced font I think. Well, I don't think it is that important. Let's get this into the next version of SageMath. Thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 10, 2025
sagemathgh-40139: Translate constructions docs into Chinese
    
* Translate constructions docs into Chinese
* Fix some typos

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions.
    
URL: sagemath#40139
Reported by: Fisher
Reviewer(s): Fisher, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 12, 2025
sagemathgh-40139: Translate constructions docs into Chinese
    
* Translate constructions docs into Chinese
* Fix some typos

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions.
    
URL: sagemath#40139
Reported by: Fisher
Reviewer(s): Fisher, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 13, 2025
sagemathgh-40139: Translate constructions docs into Chinese
    
* Translate constructions docs into Chinese
* Fix some typos

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions.
    
URL: sagemath#40139
Reported by: Fisher
Reviewer(s): Fisher, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 14, 2025
sagemathgh-40139: Translate constructions docs into Chinese
    
* Translate constructions docs into Chinese
* Fix some typos

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions.
    
URL: sagemath#40139
Reported by: Fisher
Reviewer(s): Fisher, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 15, 2025
sagemathgh-40139: Translate constructions docs into Chinese
    
* Translate constructions docs into Chinese
* Fix some typos

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

Follow PR sagemath#40049, Replace dead HTTP links in tutorial & constructions.
    
URL: sagemath#40139
Reported by: Fisher
Reviewer(s): Fisher, Travis Scrimshaw
@fisheryv fisheryv closed this Aug 17, 2025
@tscrim
Copy link
Collaborator

tscrim commented Aug 18, 2025

Should this be closed or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants