Skip to content

update m4ri to gcc-15-supporting version #40132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2025
Merged

update m4ri to gcc-15-supporting version #40132

merged 3 commits into from
Jun 1, 2025

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented May 19, 2025

this in particular corrects m4ri's pkg-config file, which is not working for gcc-15, see e.g. BRiAl/BRiAl#58 and the sage-develop posts

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase dimpase requested a review from antonio-rojas May 19, 2025 22:36
dimpase added a commit to dimpase/BRiAl that referenced this pull request May 19, 2025
@dimpase
add constraint on m4ri's version
af178af 
this will fix sagemath/sage#40132
@dimpase dimpase mentioned this pull request May 19, 2025
Merged
kiwifb pushed a commit to BRiAl/BRiAl that referenced this pull request May 19, 2025
@dimpase
add constraint on m4ri's version (#59)
2c53046 
this will fix sagemath/sage#40132
@dimpase dimpase mentioned this pull request May 20, 2025
Merged
4 tasks
@dimpase dimpase requested a review from kiwifb May 20, 2025 04:46
@chriswuthrich
Copy link
Contributor

This picks up the right version of m4ri. But my compilation then runs into an error compiling m4rie-20200125. Presumably that should also be updated to version 20250128 of m4rie. (Not that I understand any of them).

@dimpase
Copy link
Member Author

dimpase commented May 20, 2025

Thanks. I'll deal with m4rie here too.

@dimpase
Copy link
Member Author

dimpase commented May 20, 2025

@chriswuthrich - does it work now?

@chriswuthrich
Copy link
Contributor

With the added m4rie update, this now allows me to build sage completely. Huge thanks!

@chriswuthrich
Copy link
Contributor

If I'd remember what to do and how to give a positive review, I would do it, but I haven't reviewed for a long time.

@dimpase
Copy link
Member Author

dimpase commented May 20, 2025

If I'd remember what to do and how to give a positive review, I would do it, but I haven't reviewed for a long time.
@chriswuthrich

click on "Files changed" tab above, you'll see a green "Review changes" button

@chriswuthrich
Copy link
Contributor

Should we update line 4 in build/pkgs/m4rie/checksums.ini from bitbucket to github, too?

upstream_url=https://bitbucket.org/malb/m4rie/downloads/m4rie-VERSION.tar.gz
For m4rie malb has updated both, for m4ri bitbucket is behind.

I will click anyway on the positive review button. I assume that no tests are needed here, otherwise please tell me to run them. As to the correctness of the changes I have full confidence that Dima knows what he is doing....

@dimpase
Copy link
Member Author

dimpase commented May 20, 2025

Should we update line 4 in build/pkgs/m4rie/checksums.ini from bitbucket to github, too?

upstream_url=https://bitbucket.org/malb/m4rie/downloads/m4rie-VERSION.tar.gz
For m4rie malb has updated both, for m4ri bitbucket is behind.

I will click anyway on the positive review button. I assume that no tests are needed here, otherwise please tell me to run them. As to the correctness of the changes I have full confidence that Dima knows what he is doing....

The bitbucket URL is certainly still valid, I don't know whether it's the mirror, or the main site for m4ri. @malb might tell us.

@malb
Copy link
Member

malb commented May 20, 2025 •
edited
Loading

Hi all, Sorry for the confusion. For both M4RI and M4RIE Github is the main repository and Bitbucket is the mirror.

@kiwifb
Copy link
Member

kiwifb commented May 20, 2025 •
edited
Loading

This comment is now obsolete, do not mind it.

Hi all, Sorry for the confusion. For both M4RI and M4RIE Github is not the main repository and Bitbucket is the mirror.

Sorry, you sentence is a bit confusing, if github is not the main repository and bitbucket is the mirror, where is the main repository :) ?

@malb
Copy link
Member

malb commented May 20, 2025

Argh, how am I this bad at this! I've edited it now. Thanks

@dimpase
Copy link
Member Author

dimpase commented May 21, 2025 •
edited
Loading

Argh, how am I this bad at this! I've edited it now. Thanks

Cryptographers... they commicate in code on encrypted channels... T'ja.

@vbraun
Copy link
Member

vbraun commented May 21, 2025 

$ wget https://bitbucket.org/malb/m4rie/downloads/m4rie-20250128.tar.gz
HTTP ERROR response 404  [https://bitbucket.org/malb/m4rie/downloads/m4rie-20250128.tar.gz]
m4rie-20250128.tar.g 100% [================================================================================================================>]    6.56K    --.-KB/s
                          [Files: 0  Bytes: 6.56K [15.31KB/s] Redirects: 0  Todo: 0  Errors: 1

@dimpase
Copy link
Member Author

dimpase commented May 22, 2025

OK, I'll change the hosting to github

vbraun pushed a commit to vbraun/sage that referenced this pull request May 24, 2025
8410969 
sagemathgh-40132: update m4ri to gcc-15-supporting version
    
this in particular corrects m4ri's pkg-config file, which is not working
for gcc-15, see e.g. BRiAl/BRiAl#58 and the
sage-develop posts

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40132
Reported by: Dima Pasechnik
Reviewer(s): Chris Wuthrich
vbraun pushed a commit to vbraun/sage that referenced this pull request May 26, 2025
72fcd5d 
sagemathgh-40132: update m4ri to gcc-15-supporting version
    
this in particular corrects m4ri's pkg-config file, which is not working
for gcc-15, see e.g. BRiAl/BRiAl#58 and the
sage-develop posts

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40132
Reported by: Dima Pasechnik
Reviewer(s): Chris Wuthrich
vbraun pushed a commit to vbraun/sage that referenced this pull request May 28, 2025
cede9cc 
sagemathgh-40132: update m4ri to gcc-15-supporting version
    
this in particular corrects m4ri's pkg-config file, which is not working
for gcc-15, see e.g. BRiAl/BRiAl#58 and the
sage-develop posts

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40132
Reported by: Dima Pasechnik
Reviewer(s): Chris Wuthrich
@vbraun vbraun merged commit 008f6a3 into sagemath:develop Jun 1, 2025
19 of 27 checks passed
@dimpase
Copy link
Member Author

dimpase commented Jun 2, 2025

@orlitzky - can please gentoo get this update of m4ri from https://github.com/malb/m4ri/releases/tag/20250128

@orlitzky
Copy link
Contributor

orlitzky commented Jun 2, 2025

yep, done

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 5, 2025
f746678 
sagemathgh-40133: brial update to 1.2.14
    
among other upgrades, this is robust w.r.t. broken system m4ri packages
with incorrect .pc file
So this should complete the fix started in sagemath#40132

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40133
Reported by: Dima Pasechnik
Reviewer(s): Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

@kiwifb kiwifb Awaiting requested review from kiwifb

1 more reviewer

@chriswuthrich chriswuthrich chriswuthrich approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: packages: standard p: blocker / 1 s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimpase @chriswuthrich @malb @kiwifb @vbraun @orlitzky