adding typing annotations on many has_* methods #40123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2025
sagemathgh-40123: adding typing annotations on many has_* methods so that we know they return bool ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40123 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 26, 2025
sagemathgh-40123: adding typing annotations on many has_* methods so that we know they return bool ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40123 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40123: adding typing annotations on many has_* methods so that we know they return bool ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40123 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
2 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 13, 2025
sagemathgh-40196: further typing annotations for methods has_something as a sequel of sagemath#40123 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40196 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Tobias Diez, Vincent Macri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we know they return bool
📝 Checklist