reactive the code style checks using ruff #40122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobiasdiez please review ! |
tobiasdiez
reviewed
May 19, 2025
| commands = pycodestyle --select E111,E115,E21,E221,E222,E225,E227,E228,E25,E271,E272,E275,E302,E303,E305,E306,E401,E502,E701,E702,E703,E71,E72,W291,W293,W391,W605 {posargs:{toxinidir}/sage/} | ||
| pycodestyle --select E111,E222,E271,E301,E302,E303,E305,E306,E401,E502,E703,E712,E713,E714,E72,W29,W391,W605, --filename *.pyx {posargs:{toxinidir}/sage/} | ||
| commands = | ||
| pycodestyle --select E111,E115,E21,E221,E222,E225,E227,E228,E25,E271,E272,E275,E302,E303,E305,E306,E401,E502,E701,E702,E703,E71,E72,W291,W293,W391,W605 {posargs:{toxinidir}/sage/} |
There was a problem hiding this comment.
What do you think about completely removing everything related to pycodestyle from the code base? Or do you think its worth to maintain this still in parallel to ruff?
There was a problem hiding this comment.
this also checks cython files, so let us keep that for the moment
There was a problem hiding this comment.
Fair enough. For reference, cython support in ruff is astral-sh/ruff#10250.
tobiasdiez
approved these changes
May 19, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 24, 2025
sagemathgh-40122: reactive the code style checks using ruff in order to avoid fixing them again at every release ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40122 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 26, 2025
sagemathgh-40122: reactive the code style checks using ruff in order to avoid fixing them again at every release ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40122 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40122: reactive the code style checks using ruff in order to avoid fixing them again at every release ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40122 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Tobias Diez
|
Damn, this is not run by the linter ! Why is there another configuration for the linter ? |
2 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 6, 2025
follow up of sagemath#40122 about using ruff to check code formatting in the lint CI ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40208 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 8, 2025
sagemathgh-40208: add checks to the linter once again follow up of sagemath#40122 about using ruff to check code formatting in the lint CI ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40208 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40208: add checks to the linter once again follow up of sagemath#40122 about using ruff to check code formatting in the lint CI ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40208 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40208: add checks to the linter once again follow up of sagemath#40122 about using ruff to check code formatting in the lint CI ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40208 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40208: add checks to the linter once again follow up of sagemath#40122 about using ruff to check code formatting in the lint CI ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40208 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 13, 2025
sagemathgh-40208: add checks to the linter once again follow up of sagemath#40122 about using ruff to check code formatting in the lint CI ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40208 Reported by: Frédéric Chapoton Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to avoid fixing them again at every release
📝 Checklist