Fix "NotImplementedError: an immutable graph does not change name" #40110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain methods related to TSP (Travelling salesman problem) fail on immutable graphs:
This PR fixes this by setting the
_name
attribute directly instead of setting it vianame()
.Another fix would be to allow changing the name of immutable graphs by removing these two lines from
name()
:This check was introduced in #15681 and has bitten us in the past. While it seems counterintuitive for immutable graphs to have mutable attributes, the
_embedding
attribute can already be mutated viaset_embedding()
.📝 Checklist