Skip to content

Fix docstring for enumerate_totallyreal_fields_rel #40109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2025
Merged

Fix docstring for enumerate_totallyreal_fields_rel #40109

merged 1 commit into from
May 18, 2025

Conversation

Eloitor
Copy link
Contributor

@Eloitor Eloitor commented May 15, 2025

This PR fixes the docsting for enumerate_totallyreal_fields_rel.

  • Avoids using d as discriminant and index of a list.
  • Avoids using n and m for the degree.

Should we clarify this?

with absolute discriminant d \leq B;

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

fchapoton
fchapoton approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thx

@vbraun vbraun merged commit ab921ad into sagemath:develop May 18, 2025
12 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eloitor @fchapoton @vbraun