details about ruff code RET in modular folder #40199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 54dea38; changes) is ready! 🎉 |
mantepse
reviewed
Jun 3, 2025
| q = self._series_ring.gen() | ||
| E4_ZZ = ((-q*self.J_inv_ZZ().derivative())**2/(self.J_inv_ZZ()*(self.J_inv_ZZ()-1))).power_series() | ||
| return E4_ZZ | ||
| return ((-q*self.J_inv_ZZ().derivative())**2 / (self.J_inv_ZZ()*(self.J_inv_ZZ()-1))).power_series() |
There was a problem hiding this comment.
Suggested change
| return ((-q*self.J_inv_ZZ().derivative())**2 / (self.J_inv_ZZ()*(self.J_inv_ZZ()-1))).power_series() | |
| J_Inv = self.J_inv_ZZ() | |
| return ((-q * J_Inv.derivative())**2 / (J_inv * (J_inv-1))).power_series() |
mantepse
reviewed
Jun 3, 2025
| q = self._series_ring.gen() | ||
| E6_ZZ = ((-q*self.J_inv_ZZ().derivative())**3/(self.J_inv_ZZ()**2*(self.J_inv_ZZ()-1))).power_series() | ||
| return E6_ZZ | ||
| return ((-q*self.J_inv_ZZ().derivative())**3 / (self.J_inv_ZZ()**2*(self.J_inv_ZZ()-1))).power_series() |
There was a problem hiding this comment.
Suggested change
| return ((-q*self.J_inv_ZZ().derivative())**3 / (self.J_inv_ZZ()**2*(self.J_inv_ZZ()-1))).power_series() | |
| J_inv = self.J_inv_ZZ() | |
| return ((-q * J_inv.derivative())**3 / (J_inv**2 * (J_inv-1))).power_series() |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 4, 2025
mainly about small simplifications ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40199 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
|
Thanks Martin ! |
|
Possibly move the two suggestions to a new ticket? |
|
indeed, as Volker has started to use the branch, one should not include them here. As I try hard to avoid dependencies between pull requests, I will have to remember later.. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 6, 2025
sagemathgh-40199: details about ruff code RET in modular folder mainly about small simplifications ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40199 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 8, 2025
sagemathgh-40199: details about ruff code RET in modular folder mainly about small simplifications ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40199 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40199: details about ruff code RET in modular folder mainly about small simplifications ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40199 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40199: details about ruff code RET in modular folder mainly about small simplifications ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40199 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40199: details about ruff code RET in modular folder mainly about small simplifications ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40199 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly about small simplifications
📝 Checklist