Skip to content

Increase tolerance for agm #40181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Increase tolerance for agm #40181

merged 1 commit into from
Jun 14, 2025

Conversation

vbraun
Copy link
Member

@vbraun vbraun commented May 28, 2025

On 32-bit:

********************************************************************** File "src/sage/rings/complex_double.pyx", line 2293, in sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
a.agm(b, algorithm='principal') # rel tol 1e-15
Expected:
0.33817546298618006 - 0.013532696956540483I
Got:
0.33817546298618006 - 0.013532696956540503I
Tolerance exceeded in 1 of 2:
- 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 > 1e-15 **********************************************************************

@vbraun
Increase tolerance for agm
210c55b 
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in sage.rings.complex_double.ComplexDoubleElement.agm
Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 > 1e-15
**********************************************************************
dimpase
dimpase approved these changes Jun 1, 2025
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 4, 2025
2b45ed4 
sagemathgh-40181: Increase tolerance for agm
    
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in
sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 >
1e-15
**********************************************************************
    
URL: sagemath#40181
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 6, 2025
ad76f93 
sagemathgh-40181: Increase tolerance for agm
    
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in
sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 >
1e-15
**********************************************************************
    
URL: sagemath#40181
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 8, 2025
d8f93e3 
sagemathgh-40181: Increase tolerance for agm
    
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in
sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 >
1e-15
**********************************************************************
    
URL: sagemath#40181
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
9de43f0 
sagemathgh-40181: Increase tolerance for agm
    
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in
sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 >
1e-15
**********************************************************************
    
URL: sagemath#40181
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
81b82c1 
sagemathgh-40181: Increase tolerance for agm
    
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in
sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 >
1e-15
**********************************************************************
    
URL: sagemath#40181
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
7953d60 
sagemathgh-40181: Increase tolerance for agm
    
On 32-bit:

**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2293, in
sage.rings.complex_double.ComplexDoubleElement.agm Failed example:
    a.agm(b, algorithm='principal')  # rel tol 1e-15
Expected:
    0.33817546298618006 - 0.013532696956540483*I
Got:
    0.33817546298618006 - 0.013532696956540503*I
Tolerance exceeded in 1 of 2:
    - 0.013532696956540483 vs - 0.013532696956540503, tolerance 2e-15 >
1e-15
**********************************************************************
    
URL: sagemath#40181
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit 86d4e5a into sagemath:develop Jun 14, 2025
15 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dimpase dimpase dimpase approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbraun @dimpase