Skip to content

faster generating series for species #40163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 6, 2025

Conversation

mantepse
Copy link
Contributor

We compute the generating series of sums, products, compositions and restrictions directly from the generating series of the arguments, rather than computing the molecular expansion of the arguments first.

@tscrim
Copy link
Collaborator

tscrim commented May 26, 2025

This depends on #38544, correct?

@mantepse mantepse mentioned this pull request May 26, 2025
Copy link

github-actions bot commented Jun 10, 2025

Documentation preview for this PR (built with commit 6ebac00; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Jun 26, 2025

Please fix the merge conflicts; then I will review this.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 26, 2025

Linter failure unrelated to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 27, 2025
sagemathgh-40163: faster generating series for species
    
We compute the generating series of sums, products, compositions and
restrictions directly from the generating series of the arguments,
rather than computing the molecular expansion of the arguments first.
    
URL: sagemath#40163
Reported by: Martin Rubey
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 52f3346 into sagemath:develop Jul 6, 2025
26 of 29 checks passed
@mantepse mantepse deleted the faster-generating-series branch July 6, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants