Support Cython 3.1 #40156
Merged
Support Cython 3.1 #40156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Cython 3.1 binary operations are no longer wrappers, but methods. This breaks wrapperdescr_fastcall. Since this was rather hackish anyway, we replace its few uses by explicit coercions.
This reverts commit aff4910.
…revent side effects
|
Does this mean we cannot use Cython 3.0 any more? If so, this has to be reflected in build/pkgs/cython/ |
No, this should work just fine with 3.0 (all the conda CIs are green and they use 3.0 AFAIK) |
|
OK |
dimpase
approved these changes
May 27, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40156: Support Cython 3.1 In Cython 3.1 binary operations are no longer wrappers, but methods. This breaks wrapperdescr_fastcall. Since this was rather hackish anyway, we replace its few uses by explicit coercions. We also switch some modules to compile with `binding=True`, this fixes many errors with 3.1. URL: sagemath#40156 Reported by: Antonio Rojas Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cython 3.1 binary operations are no longer wrappers, but methods. This breaks wrapperdescr_fastcall.
Since this was rather hackish anyway, we replace its few uses by explicit coercions.
We also switch some modules to compile with
binding=True, this fixes many errors with 3.1.