Skip to content

update planaritry to 4.0.0.0 #40153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2025
Merged

update planaritry to 4.0.0.0 #40153

merged 3 commits into from
Jun 14, 2025

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented May 23, 2025

long overdue - also, supports gcc-15 out of the box

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase dimpase requested a review from antonio-rojas May 23, 2025 17:39
@dimpase dimpase requested a review from enriqueartal May 23, 2025 17:41
@dimpase dimpase mentioned this pull request May 23, 2025
Open
2 tasks
@enriqueartal
Copy link
Contributor

It works in Fedora 42, and the gnu17 option is no more needed now.

@orlitzky
Copy link
Contributor

You'll also need the Gentoo patch for dev-gap/digraphs

@enriqueartal
Copy link
Contributor

And this fedora patch for semigroups would help for gap_packages.

@gmou3
Copy link
Contributor

gmou3 commented May 24, 2025

works on Arch, thanks!

@antonio-rojas
Copy link
Contributor

antonio-rojas commented May 26, 2025 •
edited
Loading

The spkg-configure test doesn't work because it searches for a no longer existing header. Using planarity/graph.h, as sagelib itself does, should work (I haven't tested, I'm fully switched to meson now).

@dimpase
Copy link
Member Author

dimpase commented May 26, 2025

@antonio-rojas this should fix the regression you pointed out. Hopefully upstream has settled on the header naming scheme.

@dimpase
Copy link
Member Author

dimpase commented May 27, 2025

You'll also need the Gentoo patch for dev-gap/digraphs

I gather it's https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-gap/digraphs/files/digraphs-planarity-4.x.patch
which has to be applied to the GAP tarball (after changes in the file location)

@dimpase
Copy link
Member Author

dimpase commented Jun 1, 2025

@antonio-rojas - could you review it?

@antonio-rojas
Copy link
Contributor

Builds on Arch and uses system planarity

dimpase added 3 commits June 2, 2025 07:18
@dimpase
update planaritry
36816ac 
long overdue - also, supports gcc-15 out of the box
@dimpase
take care of deprecation of graph.h in 4.0
9e59a3e 
removed compile checks, as they were testing for a very old
planarity version, and keeping it needs figuring out the header
version to use.
@dimpase
GAP pkg digraphs patch from gentoo
9c31736
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2025

Documentation preview for this PR (built with commit 9c31736; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 4, 2025
e47251e 
sagemathgh-40153: update planaritry to 4.0.0.0
    
long overdue - also, supports gcc-15 out of the box


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40153
Reported by: Dima Pasechnik
Reviewer(s): gmou3
@dimpase dimpase mentioned this pull request Jun 5, 2025
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 6, 2025
40e6337 
sagemathgh-40153: update planaritry to 4.0.0.0
    
long overdue - also, supports gcc-15 out of the box


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40153
Reported by: Dima Pasechnik
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 8, 2025
b9294de 
sagemathgh-40153: update planaritry to 4.0.0.0
    
long overdue - also, supports gcc-15 out of the box


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40153
Reported by: Dima Pasechnik
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
8538c11 
sagemathgh-40153: update planaritry to 4.0.0.0
    
long overdue - also, supports gcc-15 out of the box


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40153
Reported by: Dima Pasechnik
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
d351626 
sagemathgh-40153: update planaritry to 4.0.0.0
    
long overdue - also, supports gcc-15 out of the box


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40153
Reported by: Dima Pasechnik
Reviewer(s): gmou3
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 9, 2025
5ef634b 
sagemathgh-40153: update planaritry to 4.0.0.0
    
long overdue - also, supports gcc-15 out of the box


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40153
Reported by: Dima Pasechnik
Reviewer(s): gmou3
@vbraun vbraun merged commit 2732aff into sagemath:develop Jun 14, 2025
26 of 28 checks passed
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 21, 2025
0b52cb0 
sagemathgh-40204: Remove pkgconf spkg
    
`pkgconf`, a.k.a. `pkg-config`, is available on all systems we support -
even on the "naked" (no homebrew/macports) macOS one can install a
formally certified/notarised package
https://github.com/donmccaughey/pkg-config_pkg - so there is no reason
to keep it in the tree.

There are big advantages to have pkg-config available at configure time,
as recognition of several crucial external spkgs, such as (open)blas,
zlib, etc. hinges upon pkg-config.
With this PR in, we proceed to remove them.

Last but not the least, it simplifies the Makefile by getting rid of
`base` target, which becomes empty


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#40011 - remove bzip2 spkg.
- sagemath#40153 - planarity spkg fix (can't build otherwise)
    
URL: sagemath#40204
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 25, 2025
0a45763 
sagemathgh-40204: Remove pkgconf spkg
    
`pkgconf`, a.k.a. `pkg-config`, is available on all systems we support -
even on the "naked" (no homebrew/macports) macOS one can install a
formally certified/notarised package
https://github.com/donmccaughey/pkg-config_pkg - so there is no reason
to keep it in the tree.

There are big advantages to have pkg-config available at configure time,
as recognition of several crucial external spkgs, such as (open)blas,
zlib, etc. hinges upon pkg-config.
With this PR in, we proceed to remove them.

Last but not the least, it simplifies the Makefile by getting rid of
`base` target, which becomes empty


## 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
- sagemath#40011 - remove bzip2 spkg.
- sagemath#40153 - planarity spkg fix (can't build otherwise)
    
URL: sagemath#40204
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

@enriqueartal enriqueartal Awaiting requested review from enriqueartal

1 more reviewer

@gmou3 gmou3 gmou3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: packages: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimpase @enriqueartal @orlitzky @gmou3 @antonio-rojas @vbraun