Use platformdirs to improve database path handling #40152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sage/env.py
Outdated
|
|
||
| def sage_data_paths(data_name: str) -> set[str]: | ||
| r""" | ||
| Search paths for database ``data_name``. |
There was a problem hiding this comment.
This can also be used in the future to search for other data files (eg. three.min.js), doesn't seem specific to databases.
There was a problem hiding this comment.
Right, this was a result of simply copy&pasting. Fixed now.
…make the subdirectory argument optional)
antonio-rojas
approved these changes
May 24, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 26, 2025
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Improve the handling of the data directories by always including the system data dirs, in addition to `SAGE_SHARE` (and it's variations). Also move the `sage_data_paths` method to `sage.env` so that it can be reused more easily. Should fix sagemath#40144. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40152 Reported by: Tobias Diez Reviewer(s): Antonio Rojas, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 28, 2025
sagemathgh-40152: Use platformdirs to improve database path handling <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Improve the handling of the data directories by always including the system data dirs, in addition to `SAGE_SHARE` (and it's variations). Also move the `sage_data_paths` method to `sage.env` so that it can be reused more easily. Should fix sagemath#40144. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40152 Reported by: Tobias Diez Reviewer(s): Antonio Rojas, Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the handling of the data directories by always including the system data dirs, in addition to
SAGE_SHARE(and it's variations). Also move thesage_data_pathsmethod tosage.envso that it can be reused more easily.Should fix #40144.
📝 Checklist
⌛ Dependencies