Skip to content

significantly faster BQFClassGroupQuotientMorphism #40150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2025
Merged

significantly faster BQFClassGroupQuotientMorphism #40150

merged 2 commits into from
Jun 1, 2025

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented May 22, 2025 •
edited
Loading

This patch implements the (very good!) suggestion from #40143, allowing us to massively improve performance and delete quite a bit of unnecessarily complicated code.

Resolves #40143.

tscrim
tscrim approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yyyyx4
Copy link
Member Author

yyyyx4 commented May 23, 2025

Thank you!

@TheBlupper
Copy link
Contributor

Does it still makes sense to factor the conductor here? I can't see any other place it's used.

sage/src/sage/quadratic_forms/bqf_class_group.py

Line 719 in 4c66095

self.f = ZZ((G.discriminant() / H.discriminant()).sqrt(extend=False)).factor()

@yyyyx4
Copy link
Member Author

yyyyx4 commented May 23, 2025

Indeed, good point. Fixed.

@yyyyx4 yyyyx4 requested a review from tscrim May 24, 2025 13:52
tscrim
tscrim approved these changes May 25, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 25, 2025

I will just mention that by removing the f attribute, this is a (public API) backwards-incompatible change. That being said, this should never have been done that way anyways and I highly doubt it was ever utilized by anyone.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 28, 2025
60cb9dd 
sagemathgh-40150: significantly faster BQFClassGroupQuotientMorphism
    
This patch implements the (very good!) suggestion from sagemath#40143, allowing
us to massively improve performance and delete quite a bit of
unnecessarily complicated code.

Resolves sagemath#40143.
    
URL: sagemath#40150
Reported by: Lorenz Panny
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 0cbf563 into sagemath:develop Jun 1, 2025
15 of 22 checks passed
@yyyyx4 yyyyx4 deleted the public/40143 branch June 4, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: quadratic forms p: major / 3 s: positive review t: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up BQFClassGroupQuotientMorphism
4 participants
@yyyyx4 @TheBlupper @tscrim @vbraun