-
-
Notifications
You must be signed in to change notification settings - Fork 650
Revision of the Khovanov polynomial #40149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let me know when this is ready and I will review it. |
Many thanks, Travis! There are still a lot of failing CI runs, but as far as I see they are all unrelated, for example in test-long a-f it is due to a missing shared library for Singular:
So I set it ready for review! |
Such CI failures are happening across many PRs right now. Anyways, I will try to take a look at it next week. |
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM now.
Thank you! |
sagemathgh-40149: Revision of the Khovanov polynomial <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> In sagemath#33965 and sagemath#33969, I introduced two methods named `khovanov_polynomial`, one for the `Link` class and the other for `KnotInfo`. Unfortunately, I misused the ring argument in both. IIRC, the analogy to the other polynomial link invariants led me to use the `base_ring` argument to specify the base ring of the polynomial. However, this was not a good idea, since the Khovanov polynomial, as a Poincaré polynomial of homology, always has integer coefficients. On the other hand, a ring argument is needed to specify the underlying homology. This will be corrected in this PR. In particular, I will deprecate the existing `base_ring` argument and introduce a new `ring` argument, which corresponds to the `ring` argument of the `khovanov_homology` method of the `Link` class. I take the occasion to remove the deprecation warning for the argument `KhoHo` released in March 2024. Furthermore, I introduce a new argument `torsion` to display the torsion parts of the integral homology according to the [KnotInfo convention](ht tps://knotinfo.math.indiana.edu/descriptions/khovanov_odd_integral_polyn omial.html). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40149 Reported by: Sebastian Oehms Reviewer(s): Travis Scrimshaw
In #33965 and #33969, I introduced two methods named
khovanov_polynomial
, one for theLink
class and the other forKnotInfo
. Unfortunately, I misused the ring argument in both. IIRC, the analogy to the other polynomial link invariants led me to use thebase_ring
argument to specify the base ring of the polynomial. However, this was not a good idea, since the Khovanov polynomial, as a Poincaré polynomial of homology, always has integer coefficients. On the other hand, a ring argument is needed to specify the underlying homology.This will be corrected in this PR. In particular, I will deprecate the existing
base_ring
argument and introduce a newring
argument, which corresponds to thering
argument of thekhovanov_homology
method of theLink
class. I take the occasion to remove the deprecation warning for the argumentKhoHo
released in March 2024.Furthermore, I introduce a new argument
torsion
to display the torsion parts of the integral homology according to the KnotInfo convention.📝 Checklist
⌛ Dependencies