Skip to content

fix pep E228 in all cython files in rings #40027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

fchapoton
Copy link
Contributor

so just adding space around modulo where it was missing

as suggested by cython-lint

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 113e679; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-40027: fix pep E228 in all cython files in rings
    
so just adding space around modulo where it was missing

as suggested by `cython-lint`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40027
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2025
sagemathgh-40027: fix pep E228 in all cython files in rings
    
so just adding space around modulo where it was missing

as suggested by `cython-lint`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40027
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request May 6, 2025
sagemathgh-40027: fix pep E228 in all cython files in rings
    
so just adding space around modulo where it was missing

as suggested by `cython-lint`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40027
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit c5c7d0b into sagemath:develop May 11, 2025
19 of 22 checks passed
@fchapoton fchapoton deleted the pep_E228_cython_rings branch May 11, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants