Skip to content

more typing annotations in combinat/posets #40021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025

Conversation

fchapoton
Copy link
Contributor

just adding a few typing annotations in combinat/posets/ folder

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Apr 29, 2025

Documentation preview for this PR (built with commit 6502638; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 1, 2025
sagemathgh-40021: more typing annotations in combinat/posets
    
just adding a few typing annotations in `combinat/posets/` folder

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40021
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2025
sagemathgh-40021: more typing annotations in combinat/posets
    
just adding a few typing annotations in `combinat/posets/` folder

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40021
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@fchapoton
Copy link
Contributor Author

back to positive after trivial merge

vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2025
sagemathgh-40021: more typing annotations in combinat/posets
    
just adding a few typing annotations in `combinat/posets/` folder

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#40021
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit 24ea3d2 into sagemath:develop May 18, 2025
9 of 18 checks passed
@fchapoton fchapoton deleted the typing_in_posets branch May 18, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants