remove deprecation in connected_components
#40098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit e0bcb57; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 27, 2025
sagemathgh-40098: remove deprecation in `connected_components` With issue sagemath#35889 and PR sagemath#35891 we have deprecate sorting by default in connected component methods for graphs. This PR removes the deprecation and sets the default value of parameter `sort` to `False`. Hence, the vertices of a connected component are no longer sorted by default. We let unchanged the behavior of method `connected_components` of returning the list of connected components sorted by non-increasing size. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40098 Reported by: David Coudert Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With issue #35889 and PR #35891 we have deprecate sorting by default in connected component methods for graphs.
This PR removes the deprecation and sets the default value of parameter
sorttoFalse. Hence, the vertices of a connected component are no longer sorted by default.We let unchanged the behavior of method
connected_componentsof returning the list of connected components sorted by non-increasing size.📝 Checklist
⌛ Dependencies